Closed
Bug 721071
Opened 13 years ago
Closed 13 years ago
Permanent orange: TEST-UNEXPECTED-FAIL | test-eml-subject.js | test-eml-subject.js::test_eml_normal_subject
Categories
(Thunderbird :: Testing Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 12.0
People
(Reporter: mconley, Assigned: standard8)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.49 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
This just showed up on our trunk builds, with the following error message:
SUMMARY-UNEXPECTED-FAIL | test-eml-subject.js | test-eml-subject.js::test_eml_normal_subject
EXCEPTION: a != b: 'An email' != 'An email - Daily'.
at: test-folder-display-helpers.js line 2842
assert_true(false,"a != b: 'An email' != 'An email - Daily'.") test-folder-display-helpers.js 2842
assert_equals("An email","An email - Daily") test-folder-display-helpers.js 2829
check_eml_window_title("An email","./evil.eml") test-eml-subject.js 31
test_eml_normal_subject() test-eml-subject.js 40
frame.js 557
frame.js 626
frame.js 669
frame.js 497
frame.js 675
server.js 179
server.js 183
This seems to be related to the patch for bug 523321.
Assignee | ||
Comment 1•13 years ago
|
||
Actually, I think its bug 593321:
'An email' != 'An email - Daily'
and we're in a call to check the window title.
Reporter | ||
Comment 2•13 years ago
|
||
Whoops - you're right. Typo.
Assignee | ||
Comment 3•13 years ago
|
||
The test isn't taking account of Mac window titles:
http://hg.mozilla.org/comm-central/annotate/bc502832e7cd/mail/base/content/messageWindow.js#l252
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mbanner
Comment 4•13 years ago
|
||
I am sorry, I did not know the title modification.
Just out of curiosity, why is not the modification applied on Mac?
Assignee | ||
Comment 5•13 years ago
|
||
This works on mac - it copies the logic in messageWindow.js.
I believe Mac does window title's differently because it shows a menu bar for the application you're in that also includes the application name. Therefore if you have a window selected you know which app you're in, and you don't need that information duplicated in the title bar.
Attachment #591643 -
Flags: review?(mconley)
Assignee | ||
Comment 6•13 years ago
|
||
I landed this earlier to fix the test bustage, feedback still welcome though.
http://hg.mozilla.org/comm-central/rev/ab375980b297
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Reporter | ||
Comment 7•13 years ago
|
||
Comment on attachment 591643 [details] [diff] [review]
The fix
Review of attachment 591643 [details] [diff] [review]:
-----------------------------------------------------------------
Mark:
Code looks good. Just one suggestion - take it or leave it. :D
-Mike
::: mail/test/mozmill/message-window/test-eml-subject.js
@@ -26,4 +26,4 @@
> >
> > let brandBundle = new StringBundle("chrome://branding/locale/brand.properties");
> > let productName = brandBundle.get("brandShortName");
> > - let expectedTitle = subject ? subject + " - " + productName : productName;
> > + let expectedTitle = subject;
I think an explanation of what's going on here might be useful for future debuggers. Just a few lines explaining the rules about window titles on OSX vs the other platforms.
Attachment #591643 -
Flags: review?(mconley) → review+
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [tb-orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•