Closed Bug 721071 Opened 9 years ago Closed 9 years ago
Permanent orange: TEST-UNEXPECTED-FAIL | test-eml-subject
.js | test-eml-subject .js::test _eml _normal _subject
This just showed up on our trunk builds, with the following error message: SUMMARY-UNEXPECTED-FAIL | test-eml-subject.js | test-eml-subject.js::test_eml_normal_subject EXCEPTION: a != b: 'An email' != 'An email - Daily'. at: test-folder-display-helpers.js line 2842 assert_true(false,"a != b: 'An email' != 'An email - Daily'.") test-folder-display-helpers.js 2842 assert_equals("An email","An email - Daily") test-folder-display-helpers.js 2829 check_eml_window_title("An email","./evil.eml") test-eml-subject.js 31 test_eml_normal_subject() test-eml-subject.js 40 frame.js 557 frame.js 626 frame.js 669 frame.js 497 frame.js 675 server.js 179 server.js 183 This seems to be related to the patch for bug 523321.
9 years ago
Actually, I think its bug 593321: 'An email' != 'An email - Daily' and we're in a call to check the window title.
The test isn't taking account of Mac window titles: http://hg.mozilla.org/comm-central/annotate/bc502832e7cd/mail/base/content/messageWindow.js#l252
I am sorry, I did not know the title modification. Just out of curiosity, why is not the modification applied on Mac?
This works on mac - it copies the logic in messageWindow.js. I believe Mac does window title's differently because it shows a menu bar for the application you're in that also includes the application name. Therefore if you have a window selected you know which app you're in, and you don't need that information duplicated in the title bar.
Attachment #591643 - Flags: review?(mconley)
I landed this earlier to fix the test bustage, feedback still welcome though. http://hg.mozilla.org/comm-central/rev/ab375980b297
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Comment on attachment 591643 [details] [diff] [review] The fix Review of attachment 591643 [details] [diff] [review]: ----------------------------------------------------------------- Mark: Code looks good. Just one suggestion - take it or leave it. :D -Mike ::: mail/test/mozmill/message-window/test-eml-subject.js @@ -26,4 +26,4 @@ > > > > let brandBundle = new StringBundle("chrome://branding/locale/brand.properties"); > > let productName = brandBundle.get("brandShortName"); > > - let expectedTitle = subject ? subject + " - " + productName : productName; > > + let expectedTitle = subject; I think an explanation of what's going on here might be useful for future debuggers. Just a few lines explaining the rules about window titles on OSX vs the other platforms.
Attachment #591643 - Flags: review?(mconley) → review+
You need to log in before you can comment on or make changes to this bug.