This just showed up on our trunk builds, with the following error message:
SUMMARY-UNEXPECTED-FAIL | test-eml-subject.js | test-eml-subject.js::test_eml_normal_subject
EXCEPTION: a != b: 'An email' != 'An email - Daily'.
at: test-folder-display-helpers.js line 2842
assert_true(false,"a != b: 'An email' != 'An email - Daily'.") test-folder-display-helpers.js 2842
assert_equals("An email","An email - Daily") test-folder-display-helpers.js 2829
check_eml_window_title("An email","./evil.eml") test-eml-subject.js 31
test_eml_normal_subject() test-eml-subject.js 40
This seems to be related to the patch for bug 523321.
Actually, I think its bug 593321:
'An email' != 'An email - Daily'
and we're in a call to check the window title.
Whoops - you're right. Typo.
The test isn't taking account of Mac window titles:
I am sorry, I did not know the title modification.
Just out of curiosity, why is not the modification applied on Mac?
Created attachment 591643 [details] [diff] [review]
This works on mac - it copies the logic in messageWindow.js.
I believe Mac does window title's differently because it shows a menu bar for the application you're in that also includes the application name. Therefore if you have a window selected you know which app you're in, and you don't need that information duplicated in the title bar.
I landed this earlier to fix the test bustage, feedback still welcome though.
Comment on attachment 591643 [details] [diff] [review]
Review of attachment 591643 [details] [diff] [review]:
Code looks good. Just one suggestion - take it or leave it. :D
@@ -26,4 +26,4 @@
> > let brandBundle = new StringBundle("chrome://branding/locale/brand.properties");
> > let productName = brandBundle.get("brandShortName");
> > - let expectedTitle = subject ? subject + " - " + productName : productName;
> > + let expectedTitle = subject;
I think an explanation of what's going on here might be useful for future debuggers. Just a few lines explaining the rules about window titles on OSX vs the other platforms.