Closed Bug 721161 Opened 11 years ago Closed 11 years ago

Add to X-Bugzilla-Changed-Fields when a new attachment is created on a bug

Categories

(Bugzilla :: Email Notifications, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: dkl, Assigned: dkl)

References

Details

Attachments

(1 file, 2 obsolete files)

Currently when an attachment's attributes are changed such as obsolete, flags, etc. words are added to the X-Bugzilla-Changed-Fields email header with those types of changes. But when a new attachment is added to a bug, nothing is added for that type of change. It would be good to have for consistency and in BMOs case we needed it for an extension that use that adds a header when a user submits their first patch (TagNewUser). 

Patch coming.
dkl
patch that adds Attachment Created to X-Bugzilla-Changed-Fields when a new attachment is added.

dkl
Assignee: email-notifications → dkl
Status: NEW → ASSIGNED
Attachment #591577 - Flags: review?(LpSolit)
Comment on attachment 591577 [details] [diff] [review]
Patch to add to changed fields header when attachment created (v1)

>=== modified file 'Bugzilla/BugMail.pm'

>+        push(@changedfields, 'Attachment Created');

This array doesn't contain description of fields, but identifiers (names) themselves. As this field doesn't exist in the fielddefs table, you should use something like attachments.created to match other attachments.* names.
Attachment #591577 - Flags: review?(LpSolit) → review-
Thanks LpSolit. Here is a new patch that fixes the field name issue.

dkl
Attachment #591577 - Attachment is obsolete: true
Attachment #592292 - Flags: review?(LpSolit)
Removed new entry in field-descs.

dkl
Attachment #592292 - Attachment is obsolete: true
Attachment #592292 - Flags: review?(LpSolit)
Attachment #597964 - Flags: review?(LpSolit)
Comment on attachment 597964 [details] [diff] [review]
Patch to add to changed fields header when attachment created (v3)

>+    # Add Attachment Created to changedfields if one or more 

s/Attachment Created/attachments.created/ + remove the trailing whitespace at the end of this line.

r=LpSolit
Attachment #597964 - Flags: review?(LpSolit) → review+
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
Thanks

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified Bugzilla/BugMail.pm
Committed revision 8116

dkl
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.