721161 - Add to X-Bugzilla-Changed-Fields when a new attachment is created on a bug

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[David Lawrence [:dkl]]

Currently when an attachment's attributes are changed such as obsolete, flags, etc. words are added to the X-Bugzilla-Changed-Fields email header with those types of changes. But when a new attachment is added to a bug, nothing is added for that type of change. It would be good to have for consistency and in BMOs case we needed it for an extension that use that adds a header when a user submits their first patch (TagNewUser). 

Patch coming.
dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to add to changed fields header when attachment created (v1)

patch that adds Attachment Created to X-Bugzilla-Changed-Fields when a new attachment is added.

dkl

Comment 2

[Frédéric Buclin]

Comment on attachment 591577 [details] [diff] [review]
Patch to add to changed fields header when attachment created (v1)

>=== modified file 'Bugzilla/BugMail.pm'

>+        push(@changedfields, 'Attachment Created');

This array doesn't contain description of fields, but identifiers (names) themselves. As this field doesn't exist in the fielddefs table, you should use something like attachments.created to match other attachments.* names.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to add to changed fields header when attachment created (v2)

Thanks LpSolit. Here is a new patch that fixes the field name issue.

dkl

Comment 4

[David Lawrence [:dkl]]

Attachment: Patch to add to changed fields header when attachment created (v3)

Removed new entry in field-descs.

dkl

Comment 5

[Frédéric Buclin]

Comment on attachment 597964 [details] [diff] [review]
Patch to add to changed fields header when attachment created (v3)

>+    # Add Attachment Created to changedfields if one or more 

s/Attachment Created/attachments.created/ + remove the trailing whitespace at the end of this line.

r=LpSolit

Comment 6

[David Lawrence [:dkl]]

Thanks

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/BugMail.pm
Committed revision 8116

dkl