Return focus to Fennec on cancelled AccountActivity attempt

RESOLVED INVALID

Status

()

P3
normal
RESOLVED INVALID
7 years ago
a year ago

People

(Reporter: aaronmt, Unassigned)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox12 affected)

Details

(Reporter)

Description

7 years ago
STR:

1. Launch Fennec
2. Tap 'Set up Firefox Sync' banner
3. Tap, 'I don't have a device with me' (org.mozilla.gecko.sync.setup.activities.AccountActivity)
4. Tap 'Cancel'

ER: Back to Fennec
AR: Back to Android application launcher

I/ActivityManager(  197): moveTaskToBack: 45
I/WindowManager(  197): createSurface Window{41c59678 com.android.launcher/com.android.launcher2.Launcher paused=false}: DRAW NOW PENDING

--
Samsung Galaxy Nexus (Android 4.0.3)
20120125040231
http://hg.mozilla.org/integration/mozilla-inbound/rev/badb5fd30031
Chenxia, please triage this. If we aren't doing anything funny with the view stack, please throw this into the Fennec Native > General component. If we are, then we can fix it :D
Assignee: nobody → liuche
After a reflow suggested in UI review, the "Cancel" button in manual Account Setup now returns to the J-PAKE display screen.

The Android Sync view stack is pretty ordinary, and leaving the app follows the default Android activity flow.
Component: Android Sync → General
Product: Mozilla Services → Fennec Native
QA Contact: android-sync → general

Updated

7 years ago
Assignee: liuche → nobody
Component: General → Android Sync
Product: Fennec Native → Mozilla Services
QA Contact: general → android-sync
Chenxia doesn't think this is on our end (Comment 2). The cancel button just does this:

  public void cancelClickHandler(View target) {
    finish();
  }

(which is how you're supposed to exit an Activity), and the manual setup click handler — which launches AccountActivity — just does this:

  public void manualClickHandler(View target) {
    Intent accountIntent = new Intent(this, AccountActivity.class);
    accountIntent.setFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION);
    startActivity(accountIntent);
    overridePendingTransition(0, 0);
  }

but I also don't see anything particularly suspicious in Fennec's code:

            intent = new Intent(mContext, SetupSyncActivity.class);
        mContext.startActivity(intent);

Ignoring this in favor of more important stuff until more information comes to light.
Priority: -- → P3

Comment 4

7 years ago
Also, if you go to Accounts & Sync > Firefox Sync  and right after that tap on system menu button, you will see "Cancel sync" (however, I think there should be "Sync now", please correct me if I'm wrong). If you tap on the "Cancel sync" button then again hit system menu button you will see again "Cancel sync" so that means sync was not canceled before. Is this problem related to the one described in this bug or should I file another bug for this?

Build: Firefox 14.0a1 (2012-04-08)
Device: LG Optimus 2X (Android 2.2)
(Reporter)

Comment 5

7 years ago
(In reply to Andreea Pod from comment #4)
>...

Correct me if I'm wrong, but there is more than likely a current Sync taking place or its the period of wait-time in-between Sync's where you can't force a Sync until the window opens again.
(In reply to Andreea Pod from comment #4)
> Also, if you go to Accounts & Sync > Firefox Sync  and right after that tap
> on system menu button, you will see "Cancel sync" (however, I think there
> should be "Sync now", please correct me if I'm wrong). If you tap on the
> "Cancel sync" button then again hit system menu button you will see again
> "Cancel sync" so that means sync was not canceled before. Is this problem
> related to the one described in this bug or should I file another bug for
> this?

It'll show "Cancel Sync" until Android believes that the sync is done.

We pretty much ignore that interrupt, so don't worry about this.
We return to the J-PAKE setup screen, and have for a while now. UI decided that "cancel" should have the same effect as "back".
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
(Assignee)

Updated

6 years ago
Component: Android Sync → Android Sync
Product: Mozilla Services → Android Background Services

Updated

a year ago
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.