Closed Bug 721184 Opened 12 years ago Closed 12 years ago

Elastic searches throw errors when returning wiki docs with no current revision

Categories

(support.mozilla.org :: Search, defect, P1)

Product:
support.mozilla.org
Component:
Search
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2012-01-24

People

(Reporter: erik, Assigned: willkg)

References

Details

(Whiteboard: u=user c=search s=2012.2 p=1 post-sprint) 

Things like this happen when searching on prod for "facebook":

Traceback (most recent call last):

 File "/data/www/support.mozilla.org/kitsune/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/support.mozilla.org/kitsune/vendor/src/django-mobility/mobility/decorators.py", line 23, in wrapper
   return f(request, *args, **kw)

 File "/data/www/support.mozilla.org/kitsune/apps/search/views.py", line 334, in search
   summary = doc.current_revision.summary

AttributeError: 'NoneType' object has no attribute 'summary'


1. Why are we indexing docs with no current rev?
2. Why are we turning them up in search?

Off the cuff, I'd say fix #1, and you get #2 for free.
Summary: Some elastic searches throw errors on wiki docs with no current revision → Elastic searches throw errors when returning wiki docs with no current revision
Grabbing this one and sliding it into this sprint after getting the ok on irc for it.
Assignee: nobody → willkg
Whiteboard: u=user c=search s=2012.2 p=1
Oops--adding post-sprint thing now.
Whiteboard: u=user c=search s=2012.2 p=1 → u=user c=search s=2012.2 p=1 post-sprint
Fixed in https://github.com/mozilla/kitsune/commit/f8ad9b4 in master.

Pretty sure this will be in 2012-01-31, so putting it in that target.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: 2012Q1 → 2012-01-31
This skipped the next-train and went straight to production.
Target Milestone: 2012-01-31 → 2012-01-24
You need to log in before you can comment on or make changes to this bug.