Send message back to java after tab selection is complete

VERIFIED FIXED in Firefox 13

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox13 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 591614 [details] [diff] [review]
patch

More fall-out from bug 719493. GeckoSoftwareLayerClient was relying on the Tab:Selected message from gecko, which we changed. This adds back that message, but we need to re-name it because we're using Tab:Selected for something different now.

(I went for Tab:SelectCompleted, but I'm open to other ideas.)
Attachment #591614 - Flags: review?(mbrubeck)
Attachment #591614 - Flags: review?(mbrubeck) → review+
(In reply to Margaret Leibovic [:margaret] from comment #0)
> Created attachment 591614 [details] [diff] [review]
> patch
> 
> More fall-out from bug 719493. GeckoSoftwareLayerClient was relying on the
> Tab:Selected message from gecko, which we changed. This adds back that
> message, but we need to re-name it because we're using Tab:Selected for
> something different now.
> 
> (I went for Tab:SelectCompleted, but I'm open to other ideas.)

Tab:SelectCompleted - not a fan
Thinking about it, there is no harm to send back Tab:Selected to Java (just confusing)
How about something like "Tab:Selected:Done"?
(Assignee)

Comment 4

6 years ago
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Thinking about it, there is no harm to send back Tab:Selected to Java (just
> confusing)

Confusing == harm.

(In reply to Matt Brubeck (:mbrubeck) from comment #3)
> How about something like "Tab:Selected:Done"?

Finkle, what do you think of that?
(In reply to Margaret Leibovic [:margaret] from comment #4)

> (In reply to Matt Brubeck (:mbrubeck) from comment #3)
> > How about something like "Tab:Selected:Done"?
> 
> Finkle, what do you think of that?

I can live with that. Sorry for the OCD.
(Assignee)

Comment 6

6 years ago
(In reply to Mark Finkle (:mfinkle) from comment #5)
> (In reply to Margaret Leibovic [:margaret] from comment #4)
> 
> > (In reply to Matt Brubeck (:mbrubeck) from comment #3)
> > > How about something like "Tab:Selected:Done"?
> > 
> > Finkle, what do you think of that?
> 
> I can live with that. Sorry for the OCD.

I appreciate the perfectionism.

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45207178a735

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/45207178a735
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
(Assignee)

Comment 8

6 years ago
Comment on attachment 591614 [details] [diff] [review]
patch

[Approval Request Comment]
This is a follow-up that should have been part of bug 719493, which has aurora approval. Without this patch, GeckoSoftwareLayerClient may have problems.
Attachment #591614 - Flags: approval-mozilla-aurora?

Comment 9

6 years ago
Comment on attachment 591614 [details] [diff] [review]
patch

[Triage Comment]
Approved for Aurora.
Attachment #591614 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 591614 [details] [diff] [review]
patch

[Triage Comment]
approved for beta as well
Attachment #591614 - Flags: approval-mozilla-beta+
Comment on attachment 591614 [details] [diff] [review]
patch

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]
Attachment #591614 - Flags: approval-mozilla-beta+
Attachment #591614 - Flags: approval-mozilla-aurora+
Verified fixed on:

Firefox 13.0a1 (2012-03-05)
20120305031045
http://hg.mozilla.org/mozilla-central/rev/433cfbd2a0da

--
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
status-firefox13: --- → verified
You need to log in before you can comment on or make changes to this bug.