721220 - Send message back to java after tab selection is complete

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: patch

More fall-out from bug 719493. GeckoSoftwareLayerClient was relying on the Tab:Selected message from gecko, which we changed. This adds back that message, but we need to re-name it because we're using Tab:Selected for something different now.

(I went for Tab:SelectCompleted, but I'm open to other ideas.)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Margaret Leibovic [:margaret] from comment #0)
> Created attachment 591614 [details] [diff] [review]
> patch
> 
> More fall-out from bug 719493. GeckoSoftwareLayerClient was relying on the
> Tab:Selected message from gecko, which we changed. This adds back that
> message, but we need to re-name it because we're using Tab:Selected for
> something different now.
> 
> (I went for Tab:SelectCompleted, but I'm open to other ideas.)

Tab:SelectCompleted - not a fan

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Thinking about it, there is no harm to send back Tab:Selected to Java (just confusing)

Comment 3

[Matt Brubeck (:mbrubeck)]

How about something like "Tab:Selected:Done"?

Comment 4

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Thinking about it, there is no harm to send back Tab:Selected to Java (just
> confusing)

Confusing == harm.

(In reply to Matt Brubeck (:mbrubeck) from comment #3)
> How about something like "Tab:Selected:Done"?

Finkle, what do you think of that?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Margaret Leibovic [:margaret] from comment #4)

> (In reply to Matt Brubeck (:mbrubeck) from comment #3)
> > How about something like "Tab:Selected:Done"?
> 
> Finkle, what do you think of that?

I can live with that. Sorry for the OCD.

Comment 6

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> (In reply to Margaret Leibovic [:margaret] from comment #4)
> 
> > (In reply to Matt Brubeck (:mbrubeck) from comment #3)
> > > How about something like "Tab:Selected:Done"?
> > 
> > Finkle, what do you think of that?
> 
> I can live with that. Sorry for the OCD.

I appreciate the perfectionism.

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45207178a735

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/45207178a735

Comment 8

[:Margaret Leibovic]

Comment on attachment 591614 [details] [diff] [review]
patch

[Approval Request Comment]
This is a follow-up that should have been part of bug 719493, which has aurora approval. Without this patch, GeckoSoftwareLayerClient may have problems.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 591614 [details] [diff] [review]
patch

[Triage Comment]
Approved for Aurora.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 591614 [details] [diff] [review]
patch

[Triage Comment]
approved for beta as well

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 591614 [details] [diff] [review]
patch

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]

Comment 12

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-03-05)
20120305031045
http://hg.mozilla.org/mozilla-central/rev/433cfbd2a0da

--
Device: HTC Desire
OS: Android 2.2