Allow closing tabs with a middle click in the Add-on Builder

VERIFIED FIXED in Builder 1.0

Status

addons.mozilla.org Graveyard
Add-on Builder
P3
enhancement
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: Thomas Bertels, Assigned: seanmonstar)

Tracking

unspecified
Builder 1.0
x86
Windows XP

Details

(Reporter)

Description

6 years ago
Being able to close the tabs by middle clicking on them would make them feel more like Firefox tabs.

It's pretty common to try it and wonder why they don't close themselves.
Old habits die hard.
(Assignee)

Comment 1

6 years ago
I agree, it's the only way I close tabs in Firefox or Chrome. It shouldn't be too hard, so we'll see based on priority.
Assignee: nobody → smcarthur
Priority: -- → P3
Target Milestone: --- → Builder 1.0
(Reporter)

Comment 2

6 years ago
The way to do it seems to be to add a listener for mousedown to attachTabs in PackageController.js and then call tab.destroy().
But do we have access to event.button there?
(Assignee)

Comment 3

6 years ago
got it working on -dev

https://github.com/mozilla/FlightDeck/commit/e19dc9fe80a703a919411c11fd4beeb290ddfdc8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

6 years ago
It works great. Thanks Sean!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.