The default bug view has changed. See this FAQ.

Tab-bar buttons are slightly too small

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Theme
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: squib, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 13.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird12 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 591644 [details]
The bug in action

Compared to Firefox, the buttons on the tab bar are slightly too small:

1) There's a top margin that makes them shorter than they should be
2) There's a 1px gap between the bottom of the hover gradient and the tab bar (see attached screenshot)
(Assignee)

Comment 1

5 years ago
Created attachment 592489 [details] [diff] [review]
patch

This patch removes the 3px top-margins. Additionally I made the tabs the same height as Firefox (27px instead of 26px) and cleaned the files from remnants of pre tabs-on-top time.
I moved the #print-preview-toolbar definition from primaryToolbar-aero.css to messenger-aero.css because it wasn't used there.
On every file I touched I removed the 'all and' from the media queries (see Bug 713822).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #592489 - Flags: ui-review?(nisses.mail)
Attachment #592489 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 592489 [details] [diff] [review]
patch

Excellent!
Attachment #592489 - Flags: ui-review?(nisses.mail) → ui-review+
(Assignee)

Updated

5 years ago
Attachment #592489 - Flags: review?(squibblyflabbetydoo) → review?(nisses.mail)
Comment on attachment 592489 [details] [diff] [review]
patch

And code looks good too.
Attachment #592489 - Flags: review?(nisses.mail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

5 years ago
Comment on attachment 592489 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 715495 which is in TB 12
User impact if declined: No
Testing completed (on c-c, etc.): No testing, only review
Risk to taking this patch (and alternatives if risky): Should have no risk, it's only css
Attachment #592489 - Flags: approval-comm-aurora?
Attachment #592489 - Flags: approval-comm-aurora? → approval-comm-aurora+
Checked in: http://hg.mozilla.org/comm-central/rev/a6e02542cfd7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Checked in:

http://hg.mozilla.org/releases/comm-aurora/rev/96355948daf9
status-thunderbird12: --- → fixed
You need to log in before you can comment on or make changes to this bug.