721249 - Tab-bar buttons are slightly too small

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Jim Porter (:squib)]

Attachment: The bug in action

Compared to Firefox, the buttons on the tab bar are slightly too small:

1) There's a top margin that makes them shorter than they should be
2) There's a 1px gap between the bottom of the hover gradient and the tab bar (see attached screenshot)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

This patch removes the 3px top-margins. Additionally I made the tabs the same height as Firefox (27px instead of 26px) and cleaned the files from remnants of pre tabs-on-top time.
I moved the #print-preview-toolbar definition from primaryToolbar-aero.css to messenger-aero.css because it wasn't used there.
On every file I touched I removed the 'all and' from the media queries (see Bug 713822).

Comment 2

[Andreas Nilsson (:andreasn)]

Comment on attachment 592489 [details] [diff] [review]
patch

Excellent!

Comment 3

[Andreas Nilsson (:andreasn)]

Comment on attachment 592489 [details] [diff] [review]
patch

And code looks good too.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 592489 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 715495 which is in TB 12
User impact if declined: No
Testing completed (on c-c, etc.): No testing, only review
Risk to taking this patch (and alternatives if risky): Should have no risk, it's only css

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/a6e02542cfd7

Comment 6

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/releases/comm-aurora/rev/96355948daf9