about:home's top sites are not always up to date

VERIFIED FIXED in Firefox 11

Status

()

VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 verified, firefox12 verified, firefox13 verified, fennec11+)

Details

Attachments

(7 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Steps to reproduce:
1. Open Fennec with empty history (you'll see a "no history" message in about:home)
2. Tap on location bar and access any web page
3. Once page is fully loaded, tap on Android's back button

Expected results:
You should see the website you've just accessed in the top sites section of about:home

Actual results:
about:home still shows "no history" message
Two birds with one stone; same thing after you setup a Sync account one will still see the Sync banner advertisement.
(Assignee)

Comment 2

7 years ago
(In reply to Aaron Train [:aaronmt] from comment #1)
> Two birds with one stone; same thing after you setup a Sync account one will
> still see the Sync banner advertisement.

Yeah, my patch for this bug should fix that too.
(Assignee)

Comment 3

7 years ago
Created attachment 591834 [details] [diff] [review]
Factor out code to load top sites in AboutHomeContent (
(Assignee)

Updated

7 years ago
Attachment #591834 - Attachment is obsolete: true
(Assignee)

Comment 4

7 years ago
Created attachment 591843 [details] [diff] [review]
(1/7) Remove unnecessary constructor arg from AboutHomeContent
Attachment #591843 - Flags: review?(blassey.bugs)
(Assignee)

Comment 5

7 years ago
Created attachment 591844 [details] [diff] [review]
(2/7) Move view attributes to layout file
Attachment #591844 - Flags: review?(blassey.bugs)
(Assignee)

Comment 6

7 years ago
Created attachment 591845 [details] [diff] [review]
(3/7) Remove onFinishInflate handling from AboutHomeContent
Attachment #591845 - Flags: review?(blassey.bugs)
(Assignee)

Comment 7

7 years ago
Created attachment 591846 [details] [diff] [review]
(4/7) Factor out code to load top sites in AboutHomeContent
Attachment #591846 - Flags: review?(blassey.bugs)
(Assignee)

Comment 8

7 years ago
Created attachment 591847 [details] [diff] [review]
(5/7) Remove redundant runnable to load addons/tabs in about:home
Attachment #591847 - Flags: review?(blassey.bugs)
(Assignee)

Comment 9

7 years ago
Created attachment 591848 [details] [diff] [review]
(6/7) Add API to AboutHomeContent to trigger updates
Attachment #591848 - Flags: review?(blassey.bugs)
(Assignee)

Comment 10

7 years ago
Created attachment 591849 [details] [diff] [review]
(7/7) Update about:home everytime it's shown
Attachment #591849 - Flags: review?(blassey.bugs)
Attachment #591843 - Flags: review?(blassey.bugs) → review+
Attachment #591844 - Flags: review?(blassey.bugs) → review+
Attachment #591846 - Flags: review?(blassey.bugs) → review+
Attachment #591847 - Flags: review?(blassey.bugs) → review+
Attachment #591848 - Flags: review?(blassey.bugs) → review+
Attachment #591849 - Flags: review?(blassey.bugs) → review+
Attachment #591845 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 12

7 years ago
Comment on attachment 591843 [details] [diff] [review]
(1/7) Remove unnecessary constructor arg from AboutHomeContent

Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.
Attachment #591843 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 13

7 years ago
Comment on attachment 591844 [details] [diff] [review]
(2/7) Move view attributes to layout file

Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.
Attachment #591844 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 14

7 years ago
Comment on attachment 591845 [details] [diff] [review]
(3/7) Remove onFinishInflate handling from AboutHomeContent

Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.
Attachment #591845 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 15

7 years ago
Comment on attachment 591846 [details] [diff] [review]
(4/7) Factor out code to load top sites in AboutHomeContent

Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.
Attachment #591846 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 16

7 years ago
Comment on attachment 591847 [details] [diff] [review]
(5/7) Remove redundant runnable to load addons/tabs in about:home

Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.
Attachment #591847 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 17

7 years ago
Comment on attachment 591848 [details] [diff] [review]
(6/7) Add API to AboutHomeContent to trigger updates

Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.
Attachment #591848 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 18

7 years ago
Comment on attachment 591849 [details] [diff] [review]
(7/7) Update about:home everytime it's shown

Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.
Attachment #591849 - Flags: approval-mozilla-aurora?
Comment on attachment 591849 [details] [diff] [review]
(7/7) Update about:home everytime it's shown

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #591849 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #591843 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #591844 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #591845 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #591846 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #591847 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #591848 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 722752
Verified fixed on:

Firefox 13.0a1 (2012-02-24)
20120224031039
http://hg.mozilla.org/mozilla-central/rev/cd120efbe4c6

Firefox 12.0a2 (2012-02-24)
20120224042008
http://hg.mozilla.org/releases/mozilla-aurora/rev/643e4dd65350

Firefox 11.0 (2012-02-24)
20120223235138
http://hg.mozilla.org/releases/mozilla-beta/rev/0e30f13e9012

--
Device: Motorola Droid 2
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
status-firefox11: fixed → verified
status-firefox12: fixed → verified
status-firefox13: --- → verified
You need to log in before you can comment on or make changes to this bug.