Closed Bug 721354 Opened 14 years ago Closed 14 years ago

about:home's top sites are not always up to date

Tracking

(firefox11 verified, firefox12 verified, firefox13 verified, fennec11+)

Status:

VERIFIED FIXED

Milestone:

Firefox 12

Tracking Flags:

Tracking

Status

firefox11

---

verified

firefox12

---

verified

firefox13

---

verified

fennec

11+

---

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(7 files, 1 obsolete file)

Factor out code to load top sites in AboutHomeContent ( 14 years ago Lucas Rocha (:lucasr) 4.68 KB, patch		Details \| Diff \| Splinter Review
(1/7) Remove unnecessary constructor arg from AboutHomeContent 14 years ago Lucas Rocha (:lucasr) 2.18 KB, patch	blassey : review+ akeybl : approval-mozilla-aurora+	Details \| Diff \| Splinter Review
(2/7) Move view attributes to layout file 14 years ago Lucas Rocha (:lucasr) 1.99 KB, patch	blassey : review+ akeybl : approval-mozilla-aurora+	Details \| Diff \| Splinter Review
(3/7) Remove onFinishInflate handling from AboutHomeContent 14 years ago Lucas Rocha (:lucasr) 8.38 KB, patch	blassey : review+ akeybl : approval-mozilla-aurora+	Details \| Diff \| Splinter Review
(4/7) Factor out code to load top sites in AboutHomeContent 14 years ago Lucas Rocha (:lucasr) 4.68 KB, patch	blassey : review+ akeybl : approval-mozilla-aurora+	Details \| Diff \| Splinter Review
(5/7) Remove redundant runnable to load addons/tabs in about:home 14 years ago Lucas Rocha (:lucasr) 1.22 KB, patch	blassey : review+ akeybl : approval-mozilla-aurora+	Details \| Diff \| Splinter Review
(6/7) Add API to AboutHomeContent to trigger updates 14 years ago Lucas Rocha (:lucasr) 7.59 KB, patch	blassey : review+ akeybl : approval-mozilla-aurora+	Details \| Diff \| Splinter Review
(7/7) Update about:home everytime it's shown 14 years ago Lucas Rocha (:lucasr) 1.37 KB, patch	blassey : review+ akeybl : approval-mozilla-aurora+	Details \| Diff \| Splinter Review

Lucas Rocha (:lucasr)

Assignee

Description

•

14 years ago

Steps to reproduce: 1. Open Fennec with empty history (you'll see a "no history" message in about:home) 2. Tap on location bar and access any web page 3. Once page is fully loaded, tap on Android's back button Expected results: You should see the website you've just accessed in the top sites section of about:home Actual results: about:home still shows "no history" message

Aaron Train [:aaronmt]

Comment 1

•

14 years ago

Two birds with one stone; same thing after you setup a Sync account one will still see the Sync banner advertisement.

Lucas Rocha (:lucasr)

Assignee

Comment 2

•

14 years ago

(In reply to Aaron Train [:aaronmt] from comment #1) > Two birds with one stone; same thing after you setup a Sync account one will > still see the Sync banner advertisement. Yeah, my patch for this bug should fix that too.

Lucas Rocha (:lucasr)

Assignee

Comment 3

•

14 years ago

Attached patch Factor out code to load top sites in AboutHomeContent ( (obsolete) — Details — Splinter Review

Lucas Rocha (:lucasr)

Assignee

Updated

•

14 years ago

Attachment #591834 - Attachment is obsolete: true

Lucas Rocha (:lucasr)

Assignee

Comment 4

•

14 years ago

Attached patch (1/7) Remove unnecessary constructor arg from AboutHomeContent — Details — Splinter Review

Attachment #591843 - Flags: review?(blassey.bugs)

Lucas Rocha (:lucasr)

Assignee

Comment 5

•

14 years ago

Attached patch (2/7) Move view attributes to layout file — Details — Splinter Review

Attachment #591844 - Flags: review?(blassey.bugs)

Lucas Rocha (:lucasr)

Assignee

Comment 6

•

14 years ago

Attached patch (3/7) Remove onFinishInflate handling from AboutHomeContent — Details — Splinter Review

Attachment #591845 - Flags: review?(blassey.bugs)

Lucas Rocha (:lucasr)

Assignee

Comment 7

•

14 years ago

Attached patch (4/7) Factor out code to load top sites in AboutHomeContent — Details — Splinter Review

Attachment #591846 - Flags: review?(blassey.bugs)

Lucas Rocha (:lucasr)

Assignee

Comment 8

•

14 years ago

Attached patch (5/7) Remove redundant runnable to load addons/tabs in about:home — Details — Splinter Review

Attachment #591847 - Flags: review?(blassey.bugs)

Lucas Rocha (:lucasr)

Assignee

Comment 9

•

14 years ago

Attached patch (6/7) Add API to AboutHomeContent to trigger updates — Details — Splinter Review

Attachment #591848 - Flags: review?(blassey.bugs)

Lucas Rocha (:lucasr)

Assignee

Comment 10

•

14 years ago

Attached patch (7/7) Update about:home everytime it's shown — Details — Splinter Review

Attachment #591849 - Flags: review?(blassey.bugs)

Brad Lassey [:blassey] (use needinfo?)

Updated

•

14 years ago

Attachment #591843 - Flags: review?(blassey.bugs) → review+

Brad Lassey [:blassey] (use needinfo?)

Updated

•

14 years ago

Attachment #591844 - Flags: review?(blassey.bugs) → review+

Brad Lassey [:blassey] (use needinfo?)

Updated

•

14 years ago

Attachment #591846 - Flags: review?(blassey.bugs) → review+

Brad Lassey [:blassey] (use needinfo?)

Updated

•

14 years ago

Attachment #591847 - Flags: review?(blassey.bugs) → review+

Brad Lassey [:blassey] (use needinfo?)

Updated

•

14 years ago

Attachment #591848 - Flags: review?(blassey.bugs) → review+

Brad Lassey [:blassey] (use needinfo?)

Updated

•

14 years ago

Attachment #591849 - Flags: review?(blassey.bugs) → review+

Brad Lassey [:blassey] (use needinfo?)

Updated

•

14 years ago

Attachment #591845 - Flags: review?(blassey.bugs) → review+

Lucas Rocha (:lucasr)

Assignee

Comment 11

•

14 years ago

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/ec7e23e01599 http://hg.mozilla.org/integration/mozilla-inbound/rev/e6a2c58123b9 http://hg.mozilla.org/integration/mozilla-inbound/rev/878b3da812e1 http://hg.mozilla.org/integration/mozilla-inbound/rev/101feb514dd0 http://hg.mozilla.org/integration/mozilla-inbound/rev/d9b4aa76311e http://hg.mozilla.org/integration/mozilla-inbound/rev/37af3f39a6b5 http://hg.mozilla.org/integration/mozilla-inbound/rev/0a548fed2a7a

Lucas Rocha (:lucasr)

Assignee

Comment 12

•

14 years ago

Comment on attachment 591843 [details] [diff] [review] (1/7) Remove unnecessary constructor arg from AboutHomeContent Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.

Attachment #591843 - Flags: approval-mozilla-aurora?

Lucas Rocha (:lucasr)

Assignee

Comment 13

•

14 years ago

Comment on attachment 591844 [details] [diff] [review] (2/7) Move view attributes to layout file Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.

Attachment #591844 - Flags: approval-mozilla-aurora?

Lucas Rocha (:lucasr)

Assignee

Comment 14

•

14 years ago

Comment on attachment 591845 [details] [diff] [review] (3/7) Remove onFinishInflate handling from AboutHomeContent Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.

Attachment #591845 - Flags: approval-mozilla-aurora?

Lucas Rocha (:lucasr)

Assignee

Comment 15

•

14 years ago

Comment on attachment 591846 [details] [diff] [review] (4/7) Factor out code to load top sites in AboutHomeContent Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.

Attachment #591846 - Flags: approval-mozilla-aurora?

Lucas Rocha (:lucasr)

Assignee

Comment 16

•

14 years ago

Comment on attachment 591847 [details] [diff] [review] (5/7) Remove redundant runnable to load addons/tabs in about:home Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.

Attachment #591847 - Flags: approval-mozilla-aurora?

Lucas Rocha (:lucasr)

Assignee

Comment 17

•

14 years ago

Comment on attachment 591848 [details] [diff] [review] (6/7) Add API to AboutHomeContent to trigger updates Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.

Attachment #591848 - Flags: approval-mozilla-aurora?

Lucas Rocha (:lucasr)

Assignee

Comment 18

•

14 years ago

Comment on attachment 591849 [details] [diff] [review] (7/7) Update about:home everytime it's shown Important fix on about:home. It won't update after you start Fennec without those patches. Mobile-only.

Attachment #591849 - Flags: approval-mozilla-aurora?

Matt Brubeck (:mbrubeck)

Comment 19

•

14 years ago

http://hg.mozilla.org/mozilla-central/rev/ec7e23e01599 http://hg.mozilla.org/mozilla-central/rev/e6a2c58123b9 http://hg.mozilla.org/mozilla-central/rev/878b3da812e1 http://hg.mozilla.org/mozilla-central/rev/101feb514dd0 http://hg.mozilla.org/mozilla-central/rev/d9b4aa76311e http://hg.mozilla.org/mozilla-central/rev/37af3f39a6b5 http://hg.mozilla.org/mozilla-central/rev/0a548fed2a7a

Status: NEW → RESOLVED

Closed: 14 years ago

Resolution: --- → FIXED

Target Milestone: --- → Firefox 12

Alex Keybl [:akeybl]

Comment 20

•

14 years ago

Comment on attachment 591849 [details] [diff] [review] (7/7) Update about:home everytime it's shown [Triage Comment] Mobile only - approved for Aurora.

Attachment #591849 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Alex Keybl [:akeybl]

Updated

•

14 years ago

Attachment #591843 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Alex Keybl [:akeybl]

Updated

•

14 years ago

Attachment #591844 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Alex Keybl [:akeybl]

Updated

•

14 years ago

Attachment #591845 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Alex Keybl [:akeybl]

Updated

•

14 years ago

Attachment #591846 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Alex Keybl [:akeybl]

Updated

•

14 years ago

Attachment #591847 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Alex Keybl [:akeybl]

Updated

•

14 years ago

Attachment #591848 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Brad Lassey [:blassey] (use needinfo?)

Comment 21

•

14 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/8ba82b64addf https://hg.mozilla.org/releases/mozilla-aurora/rev/c63bfe36d8b8 https://hg.mozilla.org/releases/mozilla-aurora/rev/e691991b6b25 https://hg.mozilla.org/releases/mozilla-aurora/rev/0902945f20d1 https://hg.mozilla.org/releases/mozilla-aurora/rev/972cd21a12f4 https://hg.mozilla.org/releases/mozilla-aurora/rev/4fa07287752a https://hg.mozilla.org/releases/mozilla-aurora/rev/582f46b817a0

tracking-fennec: --- → 11+

status-firefox11: --- → fixed

status-firefox12: --- → fixed

Aaron Train [:aaronmt]

Updated

•

14 years ago

Depends on: 722752

Cristian Nicolae (:xti)

Comment 22

•

13 years ago

Verified fixed on: Firefox 13.0a1 (2012-02-24) 20120224031039 http://hg.mozilla.org/mozilla-central/rev/cd120efbe4c6 Firefox 12.0a2 (2012-02-24) 20120224042008 http://hg.mozilla.org/releases/mozilla-aurora/rev/643e4dd65350 Firefox 11.0 (2012-02-24) 20120223235138 http://hg.mozilla.org/releases/mozilla-beta/rev/0e30f13e9012 -- Device: Motorola Droid 2 OS: Android 2.3.3

Status: RESOLVED → VERIFIED

status-firefox11: fixed → verified

status-firefox12: fixed → verified

status-firefox13: --- → verified

Nobody; OK to take it and work on it

Updated

•

5 years ago

Product: Firefox for Android → Firefox for Android Graveyard

You need to log in before you can comment on or make changes to this bug.