Closed Bug 721378 Opened 10 years ago Closed 10 years ago

Permanent orange: TEST-UNEXPECTED-FAIL | test-toolbar.js | test-toolbar.js::test_new_toolbar_with_default_tb3

Categories

(Thunderbird :: Testing Infrastructure, defect)

Product:
Thunderbird
Component:
Testing Infrastructure
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird11 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 12.0
Tracking Flags:
Tracking Status
thunderbird11 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Patch v1
1.19 KB, patch
standard8
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
The patch for bug 715565 broke some of our tests.  We're seeing the following on trunk:

SUMMARY-UNEXPECTED-FAIL | test-toolbar.js | test-toolbar.js::test_new_toolbar_with_default_tb3
  EXCEPTION: The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'.
    at: test-folder-display-helpers.js line 2842
       assert_true(false,"The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'.") test-folder-display-helpers.js 2842
       assert_equals("button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search","button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box","The currentset is incorrect.") test-folder-display-helpers.js 2829
       assert_default_tb3_settings([object XULElement],true) test-toolbar.js 96
       test_new_toolbar_with_default_tb3() test-toolbar.js 164
            frame.js 557
            frame.js 626
            frame.js 669
            frame.js 497
            frame.js 675
            server.js 179
            server.js 183
SUMMARY-UNEXPECTED-FAIL | test-toolbar.js | test-toolbar.js::test_new_toolbar_with_custom_tb3
  EXCEPTION: The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'.
    at: test-folder-display-helpers.js line 2842
       assert_true(false,"The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'.") test-folder-display-helpers.js 2842
       assert_equals("button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search","button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box","The currentset is incorrect.") test-folder-display-helpers.js 2829
       assert_default_tb3_settings([object XULElement],false) test-toolbar.js 96
       test_new_toolbar_with_custom_tb3() test-toolbar.js 204
            frame.js 557
            frame.js 626
            frame.js 669
            frame.js 497
            frame.js 675
            server.js 179
            server.js 183
Blocks: 715565
Whiteboard: [tb-orange]
Attached patch Patch v1 — — Splinter Review 
This fixes the test for me, locally.

It's a bit strange that this test seems to test the migration to TB3..."TBCurrent" might be more accurate.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Attachment #591788 - Flags: review?(mbanner)
Attachment #591788 - Flags: review?(mbanner) → review+
Attachment #591788 - Flags: approval-comm-aurora?
Landed on comm-central as http://hg.mozilla.org/comm-central/rev/09fa0d1410b9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #591788 - Flags: approval-comm-aurora? → approval-comm-aurora+
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.