Closed
Bug 721378
Opened 9 years ago
Closed 9 years ago
Permanent orange: TEST-UNEXPECTED-FAIL | test-toolbar.js | test-toolbar.js::test_new_toolbar_with_default_tb3
Categories
(Thunderbird :: Testing Infrastructure, defect)
Tracking
(thunderbird11 fixed)
RESOLVED
FIXED
Thunderbird 12.0
Tracking | Status | |
---|---|---|
thunderbird11 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.19 KB,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
The patch for bug 715565 broke some of our tests. We're seeing the following on trunk: SUMMARY-UNEXPECTED-FAIL | test-toolbar.js | test-toolbar.js::test_new_toolbar_with_default_tb3 EXCEPTION: The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'. at: test-folder-display-helpers.js line 2842 assert_true(false,"The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'.") test-folder-display-helpers.js 2842 assert_equals("button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search","button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box","The currentset is incorrect.") test-folder-display-helpers.js 2829 assert_default_tb3_settings([object XULElement],true) test-toolbar.js 96 test_new_toolbar_with_default_tb3() test-toolbar.js 164 frame.js 557 frame.js 626 frame.js 669 frame.js 497 frame.js 675 server.js 179 server.js 183 SUMMARY-UNEXPECTED-FAIL | test-toolbar.js | test-toolbar.js::test_new_toolbar_with_custom_tb3 EXCEPTION: The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'. at: test-folder-display-helpers.js line 2842 assert_true(false,"The currentset is incorrect.: 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search' != 'button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box'.") test-folder-display-helpers.js 2842 assert_equals("button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search","button-getmsg,button-newmsg,button-address,spacer,button-tag,spring,gloda-search,throbber-box","The currentset is incorrect.") test-folder-display-helpers.js 2829 assert_default_tb3_settings([object XULElement],false) test-toolbar.js 96 test_new_toolbar_with_custom_tb3() test-toolbar.js 204 frame.js 557 frame.js 626 frame.js 669 frame.js 497 frame.js 675 server.js 179 server.js 183
Assignee | ||
Comment 1•9 years ago
|
||
This fixes the test for me, locally. It's a bit strange that this test seems to test the migration to TB3..."TBCurrent" might be more accurate.
Updated•9 years ago
|
Attachment #591788 -
Flags: review?(mbanner) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #591788 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 2•9 years ago
|
||
Landed on comm-central as http://hg.mozilla.org/comm-central/rev/09fa0d1410b9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Updated•9 years ago
|
Attachment #591788 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 3•9 years ago
|
||
Landed on comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/2247f3164ac8
status-thunderbird11:
--- → fixed
Updated•8 years ago
|
Keywords: intermittent-failure
Updated•8 years ago
|
Whiteboard: [tb-orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•