721389 - New Tab Page doesn't retain zoom level

Status: RESOLVED FIXED

Description

[Loic]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
Build ID: 20120126031113

Steps to reproduce:

1/ Open a 1st new tab and show the New Tab Page
2/ Modify zoom level (Ctrl+ or Ctrl-)
3/ Open a 2nd new tab


Actual results:

In the 2nd new tab, zoom level is set to default.
In the 1st new tab, modified zoom level reverts to default.

Of course, if you quit Firefox, the zoom level is not retained.


Expected results:

Zoom level for New Tab Page should be retained.

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Confirmed, setting to NEW

Comment 2

[bogas04]

It should not zoom at all in my opinion ...

Comment 3

[Dão Gottwald [::dao]]

Would you care to share some reasoning for this opinion? :)

Comment 4

[bogas04]

If Bug 699362 is to be fixed , clearly it is expected to act how the addon manager acts , which thus doesn't allow you to zoom in.

Besides that , although we can provide option to increase thumbnail size , an user won't like to see a messy new tab with zoomed in thumbnails and scroll bars to pan it. Instead , a sober list with thumbnails should be presented which makes it easy to choose desired "predicted" page.

New Tab Page is not a webpage which requires "close inspection" etc...

Comment 5

[Dão Gottwald [::dao]]

Zooming is useful for visually impaired people. This has nothing to do with close inspection.

Comment 6

[bogas04]

Of course , for that zooming the page makes lesser sense than zooming thumbnail sizes , just like Opera and Safari ... 

Well that's just my opinion :|

Comment 7

[Bellindira Castillo [:bellindira]]

Created attachment 618408 [details] [diff] [review]
Removed isBlankPageURL condition and used about:blank instead of it because when the url is about:newtab the zoom level must be applied.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 618408 [details] [diff] [review]
Removed isBlankPageURL condition and used about:blank instead of it because when the url is about:newtab the zoom level must be applied.

Review of attachment 618408 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! I'm going to land this later today.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/9075fd99c34e

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/9075fd99c34e

Comment 11

[:Ehsan Akhgari]

This patch was in a range which caused a Ts regression, so I backed out the whole range:

https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

Please reland after investigating and fixing the regression.

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

Relanded because this is unlikely to be the cause of the Ts regression. We'll watch the graphs closely though.

https://hg.mozilla.org/integration/fx-team/rev/a284072ba169

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a284072ba169