Closed Bug 721389 Opened 10 years ago Closed 9 years ago

New Tab Page doesn't retain zoom level

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Version:
12 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 15

People

(Reporter: epinal99-bugzilla2, Assigned: bellindira)

References

Details

Attachments

(1 file)

Removed isBlankPageURL condition and used about:blank instead of it because when the url is about:newtab the zoom level must be applied.
1.17 KB, patch
ttaubert
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120126 Firefox/12.0a1
Build ID: 20120126031113

Steps to reproduce:

1/ Open a 1st new tab and show the New Tab Page
2/ Modify zoom level (Ctrl+ or Ctrl-)
3/ Open a 2nd new tab


Actual results:

In the 2nd new tab, zoom level is set to default.
In the 1st new tab, modified zoom level reverts to default.

Of course, if you quit Firefox, the zoom level is not retained.


Expected results:

Zoom level for New Tab Page should be retained.
Component: Untriaged → Tabbed Browser
OS: Windows 7 → All
Hardware: x86_64 → All
Confirmed, setting to NEW
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: New Tab Page doesn't retain zoom level → [NEWTAB] New Tab Page doesn't retain zoom level
Blocks: 455553
QA Contact: untriaged → tabbed.browser
Summary: [NEWTAB] New Tab Page doesn't retain zoom level → New Tab Page doesn't retain zoom level
It should not zoom at all in my opinion ...
Would you care to share some reasoning for this opinion? :)
If Bug 699362 is to be fixed , clearly it is expected to act how the addon manager acts , which thus doesn't allow you to zoom in.

Besides that , although we can provide option to increase thumbnail size , an user won't like to see a messy new tab with zoomed in thumbnails and scroll bars to pan it. Instead , a sober list with thumbnails should be presented which makes it easy to choose desired "predicted" page.

New Tab Page is not a webpage which requires "close inspection" etc...
Zooming is useful for visually impaired people. This has nothing to do with close inspection.
Of course , for that zooming the page makes lesser sense than zooming thumbnail sizes , just like Opera and Safari ... 

Well that's just my opinion :|
Assignee: nobody → bellindira
Status: NEW → ASSIGNED
Attachment #618408 - Attachment is patch: true
Comment on attachment 618408 [details] [diff] [review]
Removed isBlankPageURL condition and used about:blank instead of it because when the url is about:newtab the zoom level must be applied.

Review of attachment 618408 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! I'm going to land this later today.
Attachment #618408 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/integration/fx-team/rev/9075fd99c34e
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/9075fd99c34e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
This patch was in a range which caused a Ts regression, so I backed out the whole range:

https://hg.mozilla.org/mozilla-central/rev/24a6a53c714a

Please reland after investigating and fixing the regression.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanded because this is unlikely to be the cause of the Ts regression. We'll watch the graphs closely though.

https://hg.mozilla.org/integration/fx-team/rev/a284072ba169
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a284072ba169
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.