721417 - Can't drag and drop URL into about:newtab

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[James Socol [:jsocol, :james]]

Dragging and dropping a URL into blank space in about:newtab doesn't load the URL. Dropping it on the location bar or tab does.

STR:
1) Open about:newtab
2) Drag a URL from another application
3) Drop it in empty space (i.e. don't add it to the list of sites)

Expected:
URL loads in tab

Actual:
Nothing happens


Using the latest Nightly builds on Windows 7 (checked both the 32- and 64-bit builds).

Comment 1

[Daniel Holbert [:dholbert]]

Similarly, there's no effect when you drag-and-drop an HTML file or an XPI file onto about:newtab.  (the latter is mentioned in bug 722672)

Note that this works in both about:blank and at "real" web pages (e.g. at http://google.com ).
(that is to say, the dropped file gets loaded)

Comment 2

[Daniel Holbert [:dholbert]]

Setting OS --> All, as I'm encountering this on Linux as well
Mozilla/5.0 (X11; Linux x86_64; rv:13.0a1) Gecko/20120203 Firefox/13.0a1

Also: this seems to work correctly in at least one instance -- drag-and-drop of a highlighted text selection. If I have a URL in thunderbird or gedit, I can highlight the text of the URL and drag-and-drop that *selection* into about:newtab, and the URL will be loaded.  (It doesn't work if I drag an *un-highlighted* linkified URL from thunderbird, though, as noted in comment 0.)

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

When dragging new tab sites we need a Mac specific workaround to prevent a 500ms delay before the tab gets dropped. There are two changes:

1) This workaround is now really Mac specific (#ifdef).
2) We only need this when dragging a 'site', not for external drops.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Forgot to mention that (2) is the actual culprit because why we currently don't accept drops properly.

Comment 5

[Frank Yan (:fryn)]

Comment on attachment 594443 [details] [diff] [review]
patch v1

Review of attachment 594443 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/newtab/page.js
@@ +91,4 @@
>        // Workaround to prevent a delay on MacOSX due to a slow drop animation.
>        let doc = document.documentElement;
>        doc.addEventListener("dragover", this.onDragOver, false);
>        doc.addEventListener("drop", this.onDrop, false);

I think this could just be document.addEventListener instead of doc.addEventListener

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/097b38220aa7

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/097b38220aa7

Comment 9

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:13.0a1) Gecko/13.0a1 Firefox/13.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/13.0 Firefox/13.0a1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/13.0 Firefox/13.0a1

Verified with steps from comment 0 on Firefox 13, today's Nightly. URLs are now loaded when dragged into about:newtab.