The default bug view has changed. See this FAQ.

HttpChannelParent.cpp:336:0: warning: ignoring #pragma warning [-Wunknown-pragmas]

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: mayhemer)

Tracking

(Blocks: 1 bug)

Trunk
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Filing bug on this warning:
HttpChannelParent.cpp:336:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]

for this MSVC-specific line:
> 336 #pragma warning(disable : 4068)
http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/HttpChannelParent.cpp#336

The correct way to do this is demonstrated e.g. here in jsopcode.h:
> 286 #ifdef _MSC_VER
> 287 #pragma warning(push)
> 288 #pragma warning(disable:4100)
> 289 #endif
[...code that needs the warning disabled...]
> 436 #ifdef _MSC_VER
> 437 #pragma warning(pop)
> 438 #endif
http://mxr.mozilla.org/mozilla-central/source/js/src/jsopcode.h#288

That way, non-MSVC compilers don't see the pragma and won't complain about it.
(Reporter)

Updated

5 years ago
Blocks: 621446
Assignee: nobody → honzab.moz

Comment 1

5 years ago
This bug has been fixed as a part of bug 621446. Patch file being
https://bug621446.bugzilla.mozilla.org/attachment.cgi?id=605532
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.