Aero theme: Message summary toolbar looks crappy

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Message Reader UI
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sid0, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 13.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird11 fixed, thunderbird12 fixed)

Details

Attachments

(3 attachments)

Created attachment 591918 [details]
screenshot

1. The message summary toolbar looks a bit too transparent.
2. There's an extra line on top that really shouldn't be there.

Comment 1

6 years ago
We could probably fold this into bug 690241, where andreasn suggests making the background of the summary gray (so the toolbar buttons would look the same as they do in the single message view).
(Assignee)

Comment 2

6 years ago
(In reply to Jim Porter (:squib) from comment #1)
> We could probably fold this into bug 690241, where andreasn suggests making
> the background of the summary gray (so the toolbar buttons would look the
> same as they do in the single message view).

Would it be okay when I address in this bug only the border of the inline-toolbar? Such a border, but on bottom, appears also on Win7 under Classic at the header-toolbar and attachment-toolbar.
(Assignee)

Comment 3

6 years ago
Created attachment 592281 [details] [diff] [review]
patch for inline-toolbar (checked in)

Assuming the background color is made in bug 690241, this patch removes the top border in multi message view and under Vista/Win7 under Classic the bottom borders of the header-view-toolbar and attachment-view-toolbar.
Attachment #592281 - Flags: ui-review?(bwinton)
Attachment #592281 - Flags: review?(bwinton)
Comment on attachment 592281 [details] [diff] [review]
patch for inline-toolbar (checked in)

Review of attachment 592281 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Richard, sorry it's taken so log to get around to this.

I don't have my Windows box here, so it's going to be another week before I can UI-Review this.

But, the code itself looks good, so r=me in the meantime.

Thanks,
Blake.
Attachment #592281 - Flags: review?(bwinton) → review+
Comment on attachment 592281 [details] [diff] [review]
patch for inline-toolbar (checked in)

Wow, that was painful.  Multiple-blue-screens-of-death and compiler failures later, I've finally taken a look, and it seems pretty good.

ui-r=me.

Thanks,
Blake.
Attachment #592281 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/9bcb86fe84f6
Assignee: nobody → richard.marti
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
(Assignee)

Comment 7

6 years ago
Comment on attachment 592281 [details] [diff] [review]
patch for inline-toolbar (checked in)

Should this go into aurora/beta? It's just a minor CSS change to clean things up visually. It's about as low-risk as it gets.
Attachment #592281 - Flags: approval-comm-beta?
Attachment #592281 - Flags: approval-comm-aurora?

Comment 8

6 years ago
This seems to be happening on XP too. We should probably fix it there as well.
(Assignee)

Comment 9

6 years ago
It should be fixed on XP too. Do I overlooked something?

Comment 10

6 years ago
There's a bottom border on all the inline toolbars for me.
(Assignee)

Comment 11

6 years ago
Created attachment 600628 [details] [diff] [review]
Additional patch for XP

Sh.. you're right. When I look closely on my old XP monitor I see the border. Is it okay when I give the review to you for the one liner?
Attachment #600628 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Updated

6 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 12

6 years ago
Comment on attachment 600628 [details] [diff] [review]
Additional patch for XP

Looks good to me (granted, I tested it with a monkey patch).
Attachment #600628 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 13

6 years ago
Comment on attachment 600628 [details] [diff] [review]
Additional patch for XP

If the previous patch gets approval then this additional patch should also gets it.
Attachment #600628 - Flags: approval-comm-beta?
Attachment #600628 - Flags: approval-comm-aurora?
Attachment #592281 - Attachment description: patch for inline-toolbar → patch for inline-toolbar (checked in)
http://hg.mozilla.org/comm-central/rev/ea066a252af3

To make life easier for those checking in patches for you, please follow the directions below to make future patches easier to work with. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Keywords: checkin-needed
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Attachment #592281 - Flags: approval-comm-beta?
Attachment #592281 - Flags: approval-comm-beta+
Attachment #592281 - Flags: approval-comm-aurora?
Attachment #592281 - Flags: approval-comm-aurora+
Attachment #600628 - Flags: approval-comm-beta?
Attachment #600628 - Flags: approval-comm-beta+
Attachment #600628 - Flags: approval-comm-aurora?
Attachment #600628 - Flags: approval-comm-aurora+
Landed on branches:

http://hg.mozilla.org/releases/comm-aurora/rev/ad55f3cbf5cd
http://hg.mozilla.org/releases/comm-beta/rev/6fc4707897fa
status-thunderbird11: --- → fixed
status-thunderbird12: --- → fixed
I forgot to land the first patch on branches as well, so I've just done that:

http://hg.mozilla.org/releases/comm-aurora/rev/5c44d1dfbace
http://hg.mozilla.org/releases/comm-beta/rev/265e8da69008

Please can someone verify all the changes are correct. Thanks.
You need to log in before you can comment on or make changes to this bug.