72154 - Can't build JS Shell with CygWin 1.1.8

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Phil Schwartau]

Our Makfile.ref uses the uname command to determine what the OS is.
On my WinNT box, my CygWin B20 shell gives this result: 

[/]uname
WINNT


Our makefile then looks for a config file like "WINNT4.0.mk" in js/src/config.
Everything is fine. But my new CygWin 1.1.8 shell gives this result for uname: 

[/]uname
CYGWIN_NT-4.0


We have to update our make system to handle this so that CygWin 1.1.8 users 
can build the standalone JS shell ...

Comment 1

[cls]

I'm pretty sure that your cygwin b20 setup was using netscape's hacked uname. 
Afaik, cygwin's uname has always returned CYGWIN_XX-YY.  See
nsprpub/configure.in or nsprpub/config/arch.mk for cygwin uname detection logic.

Comment 2

[cls]

Attachment: Untested patch to handle unames other than netscape's version

Comment 3

[Phil Schwartau]

This patch does the trick for me on WinNT. I can now build the JS Shell 
with either CygWin 1.1.8 or Cygwin B20, no problem. 

Thank you for doing this !!!

Comment 4

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 5

[cls]

Patch has been checked in.

Comment 6

[Phil Schwartau]

Marking Verified -