721626 - Video controls' fullscreen button exits fullscreen when in a fullscreen document

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

STR:
1. Load http://pearce.org.nz/full-screen/
2. Press 'f' key. A <div> which contains the video will be set as the fullscreen element.
3. Click the fullscreen button on the video element's controls. Fullscreen mode exits.

Expected result:
* The video should become the fullscreen element (the controls should call video.mozRequestFullScreen()).

I imagine the video controls are showing the exit button if document.mozFullScreen, whereas it should really only show the exit button if document.mozFullScreenElement==video.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug 721626

The patch is a simple one-line fix for this bug. It'd be great to get this landed in time for Fx12.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 592215 [details] [diff] [review]
Patch for bug 721626

are there tests for this stuff?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #2)
> Comment on attachment 592215 [details] [diff] [review]
> Patch for bug 721626
> 
> are there tests for this stuff?

There is a bug on file to add tests for it (bug 704924). Some of the confusion related to adding tests has recently been figured out (bug 718107) so we might  have a workaround that we can use for writing those tests.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/a6e8ef1ef926

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a6e8ef1ef926