Add some canvas optimizations for thumbnail generation

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Trunk
Firefox 12
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 verified, firefox12 verified, firefox13 verified)

Details

Attachments

(1 attachment)

Created attachment 592064 [details] [diff] [review]
patch

We can use some simple optimizations to speed up the canvas rendering of the screenshot:
* Use -moz-opaque attribute: to tell the canvas it will not need to worry about transparency
* DRAWWINDOW_DO_NOT_FLUSH: to tell the canvas to not worry about any pending layout changes

Windows taskbar previews and Panorama both use these tweaks too. We use it in XUL Fennec too!
Attachment #592064 - Flags: review?(mbrubeck)
Assignee: nobody → mark.finkle
OS: Linux → Android
Hardware: x86 → All
Version: unspecified → Trunk
Attachment #592064 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/f5784f097de3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
mfinkle, please request approval for aurora
Comment on attachment 592064 [details] [diff] [review]
patch

[Approval Request Comment]
Just adding some know optimizations to our thumbnail generation
User impact if declined: Slower thumbnails
Risk to taking this patch (and alternatives if risky): Low risk
Attachment #592064 - Flags: approval-mozilla-aurora?

Comment 5

6 years ago
Comment on attachment 592064 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Beta 11.
Attachment #592064 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Verified fixed on:

Firefox 13.0a1 (2012-02-06)
20120206031148
http://hg.mozilla.org/mozilla-central/rev/814d0b2dbaba
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED

Updated

6 years ago
status-firefox11: fixed → verified
status-firefox12: --- → verified
status-firefox13: --- → verified
You need to log in before you can comment on or make changes to this bug.