Closed
Bug 721640
Opened 13 years ago
Closed 13 years ago
Perf: slowness in load of about:config
Categories
(Firefox for Android Graveyard :: General, defect, P4)
Tracking
(firefox12 affected, firefox14 fixed, firefox15 verified, firefox16 verified, blocking-fennec1.0 -, fennec-)
RESOLVED
FIXED
Firefox 16
People
(Reporter: nhirata, Assigned: bnicholson)
References
Details
(Keywords: perf, Whiteboard: [has-regression-range])
Attachments
(2 files)
2.42 KB,
patch
|
Details | Diff | Splinter Review | |
1.02 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1. go to about:config
Expected: config will load fairly quickly
Actual: white screen and have to wait about 2 to 5 seconds
Note: 1/26/2012 build, Galaxy S Captivate, 2.2
Comment 1•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5c2bc94d359c&tochange=e46cca506613
bug 717283?
status-firefox12:
--- → affected
Whiteboard: [has-regression-range]
Comment 2•13 years ago
|
||
cc'ing margaret
Updated•13 years ago
|
tracking-fennec: --- → -
Priority: -- → P4
Comment 3•13 years ago
|
||
This is a dead-simple way to make the about:config page render faster. It limits the number of displayed items, and shows a message to refine your search if more items are found.
Comment 4•13 years ago
|
||
Adding Brian, since he was also playing around with improving about:config.
Assignee | ||
Comment 9•13 years ago
|
||
This has been annoying me recently, so here's a simple patch that shows no entries when the filter is empty.
Attachment #630762 -
Flags: review?(mark.finkle)
Comment 10•13 years ago
|
||
Comment on attachment 630762 [details] [diff] [review]
patch
This should be OK since we have a "Search Settings" placeholder string in the editbox, giving the user a hint as to what to do.
Attachment #630762 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 11•13 years ago
|
||
Assignee: nobody → bnicholson
Assignee | ||
Comment 12•13 years ago
|
||
Comment on attachment 630762 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: about:config takes several (10-15) seconds to load; gecko is frozen during this period
Testing completed (on m-c, etc.):
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none
Attachment #630762 -
Flags: approval-mozilla-beta?
Attachment #630762 -
Flags: approval-mozilla-aurora?
Comment 13•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d95dca51a833
(Merged by Ed Morley)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Updated•13 years ago
|
Attachment #630762 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 14•13 years ago
|
||
status-firefox15:
--- → fixed
status-firefox16:
--- → fixed
Comment 15•13 years ago
|
||
Comment on attachment 630762 [details] [diff] [review]
patch
[Triage Comment]
Approving low-risk fix for beta, but please only land on tip of mozilla-beta (this will go out in Fennec 14.0.1)
Attachment #630762 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 16•13 years ago
|
||
status-firefox14:
--- → fixed
Comment 17•13 years ago
|
||
There are no entries displayed when there is no search string entered. Once the user searches for a setting the results are displayed in a timely manner.
Tested on:
Nightly 16.0a1 2012-06-19/ Aurora 15.0a2 2012-06-19
HTC Desire
Android 2.2
Patch has not made it in Firefox Mobile 14 Beta 7. Leaving the issue open for verification on Beta 8.
Comment 18•13 years ago
|
||
The patch has made it in Firefox 14 Beta 10. I'm leaving this resolved/fixed until the issues in Bug 764410 and Bug 770873 are fixed.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•