721765 - Typo in Start Page empty top sites string

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: screeshot

Currently reads: 
"You do no have any top sites at the moment. Tap the Title bar to start browsing."

Should read: 
"You do not have any top sites at the moment. Tap the Title Bar to start browsing."

Please change "no" to "not" and "bar" to "Bar"

Comment 1

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/mozilla-aurora/source/mobile/android/base/locales/en-US/android_strings.dtd#103

/summon :lucasr

Comment 2

[Axel Hecht [:Pike]]

Not-string-change for this one.

I find the capitalization of "Title bar" weird, too, fwiw.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Axel Hecht [:Pike] from comment #2)
> Not-string-change for this one.
> 
> I find the capitalization of "Title bar" weird, too, fwiw.

Ian, Madhava, confirm that Title Bar should capitalized? Just double-checking.

Comment 4

[Ian Barlow (:ibarlow)]

Lucas, yes please capitalize both words. Title Bar.

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: Fix typo in about:home's top sites string

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 592721 [details] [diff] [review]
Fix typo in about:home's top sites string

That's good without key change, too.

Comment 7

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/f97d3584b395

Comment 8

[Lucas Rocha (:lucasr)]

Comment on attachment 592721 [details] [diff] [review]
Fix typo in about:home's top sites string

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 592721 [details] [diff] [review]
Fix typo in about:home's top sites string

let's get this string-only, mobile-only change in aurora soon

Comment 10

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/f97d3584b395

Comment 11

[Paul Feher]

Verified on:
Nightly Fennec 13.0a1 (2012-03-05)
Aurora Fennec 12.0a2 (2012-03-05)
Device: HTC Desire Z
OS: Android 2.3.3

The text displayed now is: 
"You do not have any top sites yet. Tap the Title Bar to start browsing."