721769 - "Enter Search or Address" cut off in header

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Ian Barlow (:ibarlow)]

Attachment: screenshot

This brings up a broader issue we should take a look at in the title bar: It appears we truncate text to accomodate space for a lock icon, *whether or not the lock icon is displayed*. 

We should be letting the text fill more of the title bar, and only truncate earlier when there is a security lock to display.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Since there is the Stop/Site-security icon, it's hard to extend the text till there. Changing the margin based on visibility of stop/security icon will be cumbersome task. Do we want to add this logic?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #1)
> Since there is the Stop/Site-security icon, it's hard to extend the text
> till there. Changing the margin based on visibility of stop/security icon
> will be cumbersome task. Do we want to add this logic?

Sounds like we do want to try making extra space. Use margins or whatever other ideas you might have.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch sets the padding based on whether stop/site-security is visible or not. This doesn't cut off text if there is space.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/mozilla-central/rev/3488a35dc829

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 594360 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
ICS will have a chopped text on first-run (and subsequent runs with no tabs to restore)

Testing completed (on m-c, etc.): Landed and tested on m-c on 02/06

Risk to taking this patch (and alternatives if risky): None. This is just a very small UI change.

String changes made by this patch: None.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 594360 [details] [diff] [review]
Patch

Mobile-only and low risk UI polish

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dbe501301fcf

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/c6ab50b5a5fa

Comment 9

[Camelia Urian]

Is this bug supposed to me marked as Resolved Fixed?

Comment 10

[Aaron Train [:aaronmt]]

Yes.

Comment 11

[Camelia Urian]

Nightly 13.0a1 (2012-02-07)
Aurora 12.0a2 (2012-02-07)
Beta 11.0 (20120206202409 - http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116)
Device: Samsung Google Nexus S - Android 2.3.6

Verified Fixed