Closed Bug 721769 Opened 10 years ago Closed 10 years ago

"Enter Search or Address" cut off in header

Categories

(Firefox for Android Graveyard :: General, defect, P3)

11 Branch
ARM
Android
defect

Tracking

(firefox11 verified, firefox12 verified, firefox13 verified, fennec+)

VERIFIED FIXED
Tracking Status
firefox11 --- verified
firefox12 --- verified
firefox13 --- verified
fennec + ---

People

(Reporter: ibarlow, Assigned: sriram)

Details

Attachments

(2 files)

Attached image screenshot
This brings up a broader issue we should take a look at in the title bar: It appears we truncate text to accomodate space for a lock icon, *whether or not the lock icon is displayed*. 

We should be letting the text fill more of the title bar, and only truncate earlier when there is a security lock to display.
OS: Mac OS X → Android
Hardware: x86 → ARM
Assignee: nobody → sriram
tracking-fennec: --- → +
Priority: -- → P3
Since there is the Stop/Site-security icon, it's hard to extend the text till there. Changing the margin based on visibility of stop/security icon will be cumbersome task. Do we want to add this logic?
(In reply to Sriram Ramasubramanian [:sriram] from comment #1)
> Since there is the Stop/Site-security icon, it's hard to extend the text
> till there. Changing the margin based on visibility of stop/security icon
> will be cumbersome task. Do we want to add this logic?

Sounds like we do want to try making extra space. Use margins or whatever other ideas you might have.
Attached patch PatchSplinter Review
This patch sets the padding based on whether stop/site-security is visible or not. This doesn't cut off text if there is space.
Attachment #594360 - Flags: review?(mark.finkle)
Attachment #594360 - Flags: review?(mark.finkle) → review+
Comment on attachment 594360 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
ICS will have a chopped text on first-run (and subsequent runs with no tabs to restore)

Testing completed (on m-c, etc.): Landed and tested on m-c on 02/06

Risk to taking this patch (and alternatives if risky): None. This is just a very small UI change.

String changes made by this patch: None.
Attachment #594360 - Flags: approval-mozilla-beta?
Attachment #594360 - Flags: approval-mozilla-aurora?
Comment on attachment 594360 [details] [diff] [review]
Patch

Mobile-only and low risk UI polish
Attachment #594360 - Flags: approval-mozilla-beta?
Attachment #594360 - Flags: approval-mozilla-beta+
Attachment #594360 - Flags: approval-mozilla-aurora?
Attachment #594360 - Flags: approval-mozilla-aurora+
Is this bug supposed to me marked as Resolved Fixed?
Yes.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Nightly 13.0a1 (2012-02-07)
Aurora 12.0a2 (2012-02-07)
Beta 11.0 (20120206202409 - http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116)
Device: Samsung Google Nexus S - Android 2.3.6

Verified Fixed
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.