721918 - use configparser instead of a crazy bunch of regexes to read application.ini

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

currently talos.run_tests.browserInfo uses a crazy bunch of regexes in
an if-else tree to read a .ini file.  This is silly.  We can just use
ConfigParser.

Comment 1

[Jason Yeo[:jyeo]]

Attachment: 721918.patch

Hi, I have a patch to replace those nasty regexes. Let me know if I am doing it correctly.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 596132 [details] [diff] [review]
721918.patch

Review of attachment 596132 [details] [diff] [review]:
-----------------------------------------------------------------

I like this a lot, simple fix;

Comment 3

[Jeff Hammel]

Comment on attachment 596132 [details] [diff] [review]
721918.patch

looks good to me! thanks!

Comment 4

[Mozilla RelEng Bot]

Try run for d8fd8d4cfed6 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d8fd8d4cfed6
Results (out of 73 total builds):
    success: 73
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-d8fd8d4cfed6

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/a134a15e8a6c