Watcher should have option to disable starting SUTAgent

RESOLVED FIXED in mozilla15

Status

Testing
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Trunk
mozilla15
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Quoting ctalbert:

<ctalbert> wlach: well, the watcher tries every so often to start the agent, and if it can't find the agent it will throw some kind of exception.  While it's throwing this exception it's causing a lot of churn under the covers and on systems where you're not using the agent (like editicker) you don't want that affecting your perfromance numbers

I concured, so I wrote a patch. This bug is about this patch.
Created attachment 592339 [details] [diff] [review]
Patch to make watcher optionally not restart SUTAgent when it's not around

The default behaviour is the same. This patch's behaviour is only applied when you have a watcher.ini (/data/data/com.mozilla.watcher/files/watcher.ini) file that looks like this:

[watcher]
startSUTAgent = false
strikes = 0

(the strikes option disables the restart-device-when-network-is-unreachable behaviour, which was already configurable but probably something you'd want to enable here)

This patch also implements some minor cleanup to improve legibility in various places related to this bug. Nothing major though.
Assignee: nobody → wlachance
Attachment #592339 - Flags: review?(ctalbert)
Attachment #592339 - Attachment description: Patch to make watcher optionally not restart fennec when it's not around → Patch to make watcher optionally not restart SUTAgent when it's not around

Comment 2

6 years ago
Comment on attachment 592339 [details] [diff] [review]
Patch to make watcher optionally not restart SUTAgent when it's not around

looks good.
Attachment #592339 - Flags: review?(ctalbert) → review+
Inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/a3159c7545f8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Note: don't mark things as fixed when you've only landed on inbound. :)

https://hg.mozilla.org/mozilla-central/rev/a3159c7545f8
You need to log in before you can comment on or make changes to this bug.