Closed Bug 722050 Opened 14 years ago Closed 14 years ago

Checker-boarding on about:home once again

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 affected, firefox12 verified, fennec11+)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- affected
firefox12 --- verified
fennec 11+ ---

People

(Reporter: aaronmt, Assigned: lucasr)

References

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot - Nightly (01/28)
241.60 KB, image/png
Details
Fix about:home checker-boarding
2.20 KB, patch
mfinkle
: review+
mfinkle
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Starting up Fennec and viewing about:home displays the bottom third as checkerboard. See screenshot. -- Samsung Galaxy Nexus (Android 4.0.2) Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120128 Firefox/12.0a1 Fennec/12.0a1
tracking-fennec: --- → ?
about:home isn't rendered by Gecko, so the problem here is that however that is done is showing the Gecko layers underneath it - it's checkerboard because when about:home comes up for the first time, Gecko hasn't done any drawing and so there's nothing to show. Please Cc someone that works on the about:home display for this, this isn't a Java compositor issue.
I suspect that http://hg.mozilla.org/integration/mozilla-inbound/rev/e6a2c58123b9 is causing this somehow. Let me confirm.
Assignee: nobody → lucasr.at.mozilla
The old code called setScrollContainer(true), the new layout says isScrollContainer="false". Is that intentional?
(In reply to Chris Lord [:cwiiis] from comment #4) > The old code called setScrollContainer(true), the new layout says > isScrollContainer="false". Is that intentional? Nope. Good catch.
Attachment #592722 - Flags: review?(mark.finkle)
(In reply to Lucas Rocha (:lucasr) from comment #6) > Created attachment 592722 [details] [diff] [review] > Fix about:home checker-boarding This is reverting the commit I mentioned above. Attributes in the "merge" element don't seem to have any effect.
Attachment #592722 - Flags: review?(mark.finkle) → review+
Comment on attachment 592722 [details] [diff] [review] Fix about:home checker-boarding Non-risky patch. Small change. Fixes strange visual glitch in about:home.
Attachment #592722 - Flags: approval-mozilla-aurora?
Comment on attachment 592722 [details] [diff] [review] Fix about:home checker-boarding this patch backs out a patch that was also approved for aurora
Attachment #592722 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: ? → 11+
https://hg.mozilla.org/mozilla-central/rev/596709924d33
Status: NEW → RESOLVED
Closed: 14 years ago
status-firefox12: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Verified on M-C Samsung Galaxy Nexus (Android 4.0.2) Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120131 Firefox/12.0a1 Fennec/12.0a1 Please land on Aurora.
Status: RESOLVED → VERIFIED
status-firefox11: --- → affected
status-firefox12: fixed → verified
Keywords: checkin-needed
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: