Closed Bug 722051 Opened 8 years ago Closed 6 years ago

Sessionstore.js being truncated after restart and a few tabs not restored

Categories

(Firefox :: Session Restore, defect, critical)

9 Branch
x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: account, Unassigned)

Details

(Keywords: dataloss)

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912

Steps to reproduce:

Restarted FF after a closure of FF (Crash, reboot, close etc).
I have FF set to restore sessions (if it can, it rarely does without "Oops").
I have many windows and tabs open (but I have enough RAM to spare).


Actual results:

The sessionstore.js file is smaller than it was (truncated) so only some of my windows and tabs are restored (most of them are).
I know this as I take regular backups of the .js and .bak files (as I have had various problems with bookmarks/session info over time) and I compare the sizes from different dates (the number of windows and tabs changes infrequently on a day to day basis).
The most recent file was ~4MB and the backup file from the last session is ~8/9MB.

It seems FF *sometimes* truncates the file *somehow*.  I have not tried to reproduce as it seems to happen depending on when/how FF terminates, and when the session is at the same or simialr state (i.e. I have restored a backup or .bak file and at some point the file is truncated again (I am currently using a store from 23/1/2012))

I have recently had to restart my computer many times and hence this happened a few times.  I also have FF crash A LOT when it consumes too much memory (the crash tool sends you guys an error report) and thus I have seen this problem many times in the last few days.


Expected results:

As per design - the sessionstore.js should contain the tabs and windows from the last save of the session, and I did not close the windows/tabs that are missing at any point prior to the crash/close/restart.
I have not submitted my sessionstore.js as I am not sure if any personal data is located within.
Component: Untriaged → Session Restore
DarkHorse, sorry for not responding sooner. Are you still having this issue?
It has happened recently a few (undocumented) times, but only with 1 or 2 sites so I re-loaded them manually. (in the latest update, the "welcome to Firefox" post-upgrade message keeps reappearing after session restores as the second tab of the "oops" page)

Have you guys heard of this issue before?

Also could you comment on whether you'd like to see the affected sessionstore.js, and whether any sensitive data is contained within?
(In reply to DarkHorseDre from comment #3)
> It has happened recently a few (undocumented) times, but only with 1 or 2
> sites so I re-loaded them manually. (in the latest update, the "welcome to
> Firefox" post-upgrade message keeps reappearing after session restores as
> the second tab of the "oops" page)

That sounds like it's either crashing before upgrading...

> Have you guys heard of this issue before?

No.

> Also could you comment on whether you'd like to see the affected
> sessionstore.js, and whether any sensitive data is contained within?

It would be interesting to see the file. There is probably sensitive data within - at least history, very likely session cookies, form data. I wouldn't upload it to bugzilla. I'd be happy to take a look at it if want to share. I use a personal email for bugzilla, but I'm a mozilla employee and can be reached at oshannessy@mozilla.com if that's more comfortable for you to email.
Hello Paul,

I Wrote that email very late last-night (this morning!) - allow me to clarify:

I was asking if you guys have seen instances of the sessionstore being truncated/corrupted, not the tab issue (although I can tell you the upgrade completed successfully, however the upgrade page must be 'stuck' in the sessionstore, hence why it appears after every restart?)

OK I'll send you the truncated file and another recent (but not most recent file)

Please delete this file after inspection.
QA Contact: untriaged → session.restore
results ?
Yes good question, I've been meaning to ask that too - I sent my file over back then..
Sorry, more important things came up and I never did finish investigating. I've since lost access to that email so don't have those files you sent. Is this still a problem?
Hi,
I understand.

I'm guessing you are asking if I have experienced the failure since? The answer is yes, but then I have been working around it (awkwardly).

I'd assume that if no changes have been made to the code to correct this, then the problem still exists.
(In reply to DarkHorseDre from comment #0)
> User Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101
> Firefox/9.0.1
> Build ID: 20111220165912
> 
> Steps to reproduce:
> 
> Restarted FF after a closure of FF (Crash, reboot, close etc).
> I have FF set to restore sessions (if it can, it rarely does without "Oops").
> I have many windows and tabs open (but I have enough RAM to spare).
>...
> The sessionstore.js file is smaller than it was (truncated) so only some of
> my windows and tabs are restored (most of them are).
>...
> It seems FF *sometimes* truncates the file *somehow*.  I have not tried to
> reproduce as it seems to happen depending on when/how FF terminates,

Are you still seeing this problem when using a current version?
Severity: normal → critical
Flags: needinfo?(account)
Keywords: dataloss
(In reply to Wayne Mery (:wsmwk) from comment #10)
> (In reply to DarkHorseDre from comment #0)
> > User Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101
> > Firefox/9.0.1
> > Build ID: 20111220165912
> > 
> > Steps to reproduce:
> > 
> > Restarted FF after a closure of FF (Crash, reboot, close etc).
> > I have FF set to restore sessions (if it can, it rarely does without "Oops").
> > I have many windows and tabs open (but I have enough RAM to spare).
> >...
> > The sessionstore.js file is smaller than it was (truncated) so only some of
> > my windows and tabs are restored (most of them are).
> >...
> > It seems FF *sometimes* truncates the file *somehow*.  I have not tried to
> > reproduce as it seems to happen depending on when/how FF terminates,
> 
> Are you still seeing this problem when using a current version?

Hi,
As it occurred consistently since (and before) reporting, and as I didn't get a response after sending my sessionstore.js file, I assumed the problem has not been fixed, so in the end I stopped using FF as the main browser on that machine.

If I recollect correctly, I did try creating a new FF profile and using the same sessionstore.js and the problem remained.

I definitely think it is a problem with a large number of tabs and windows being open simultaneously, and the proof would probably have been in my sessionstore.js..

I haven't seen this mentioned so let me ask: what do you guys need to definitively assess this issue?
Has anyone else ever reported losing tabs on FF session restore?
Has anyone tried to reproduce any part of this?
Flags: needinfo?(account)
It's possible thtat the problem still exists. But your last work is on such an old version that it's best to assess based on a current version, or perhaps even better by using the current beta at http://www.mozilla.org/en-US/firefox/channel/

If you crash or lose data on restart when using the newer current version or current beta, please comment in the bug.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Summary: Sessionstore.js being truncated after restart → Sessionstore.js being truncated after restart and a few tabs not restored
You need to log in before you can comment on or make changes to this bug.