Obsolete GenerateCCTestBuilder

RESOLVED FIXED

Status

SeaMonkey
Release Engineering
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

7 years ago
GenerateTestBuilder has changed since we last touched this, this is to update for more changes.
(Assignee)

Comment 1

7 years ago
Created attachment 592420 [details] [diff] [review]
diff -w (for ease of inspection) [buildbotcustom.1]
(Assignee)

Comment 2

7 years ago
Created attachment 592421 [details] [diff] [review]
[buildbotcustom.1] Bring up to date
(Assignee)

Comment 3

7 years ago
Actually after doing this, I realize that Generate*CC*TestBuilder is identical to GenerateTestBuilder, so morphing to just obsolete this, (will land as two patches)
Summary: Update GenerateCCTestBuilder for changes in GenerateTestBuilder → Obsolete GenerateCCTestBuilder
(Assignee)

Comment 4

7 years ago
Created attachment 592424 [details] [diff] [review]
[buildbotcustom.2] Actually Obsolete it.
(Assignee)

Comment 5

7 years ago
Created attachment 592425 [details] [diff] [review]
[buildbot-configs] obsolete it for SeaMonkey Release Stuff
(Assignee)

Updated

7 years ago
Attachment #592420 - Attachment description: diff -w (for ease of inspection) → diff -w (for ease of inspection) [buildbotcustom.1]
(Assignee)

Updated

7 years ago
Attachment #592421 - Attachment description: Bring up to date → [buildbotcustom.1] Bring up to date
(Assignee)

Updated

7 years ago
Attachment #592424 - Attachment description: Actually Obsolete it. → [buildbotcustom.2] Actually Obsolete it.

Comment 6

7 years ago
If we're sure that changes in GenerateTestBuilder will not break us unintentionally, then I guess that's OK. I think this and the potential of supporting tests for mailnews stuff that Firefox doesn't run were the main reasons for forking this.
(Assignee)

Comment 7

7 years ago
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #6)
> If we're sure that changes in GenerateTestBuilder will not break us
> unintentionally, then I guess that's OK. I think this and the potential of
> supporting tests for mailnews stuff that Firefox doesn't run were the main
> reasons for forking this.

We were forked at one point here, and I feel that matching where possible is better than not and breaking. I intend to keep an eye on changes as I merge them in, and if we break I'll work fast to fix.

We can always re-fork if need be.
You need to log in before you can comment on or make changes to this bug.