722080 - xpc_qsGetWrapperCache users in CustomQS_Canvas2D.h seem broken

Status: RESOLVED DUPLICATE of bug 734668

(Core :: XPConnect, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

They have

nsCOMPtr<nsISupports> resultInterface;
...
qsObjectHelper helper(resultInterface,
                      xpc_qsGetWrapperCache(resultInterface))

and all we have in implementations is

xpc_qsGetWrapperCache(nsWrapperCache *cache) { return cache; }
xpc_qsGetWrapperCache(void *p) { return nsnull; }

so this just passes null to qsObjectHelper, right?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yes.  Why is that a problem per se?  Do these objects actually inherit from nsWrapperCache?  If not, then passing null is the right thing to do.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

They don't inherit from nsWrapperCache, but why write null as xpc_qsGetWrapperCache(resultInterface) when you can write it as NULL?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Probably because it just expanded out codegened worker code...

I wouldn't worry too much about this; this stuff is on the short-list for new-bindings.