Closed Bug 722080 Opened 13 years ago Closed 11 years ago

xpc_qsGetWrapperCache users in CustomQS_Canvas2D.h seem broken

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 734668

People

(Reporter: Ms2ger, Unassigned)

Details

They have

nsCOMPtr<nsISupports> resultInterface;
...
qsObjectHelper helper(resultInterface,
                      xpc_qsGetWrapperCache(resultInterface))

and all we have in implementations is

xpc_qsGetWrapperCache(nsWrapperCache *cache) { return cache; }
xpc_qsGetWrapperCache(void *p) { return nsnull; }

so this just passes null to qsObjectHelper, right?
Yes.  Why is that a problem per se?  Do these objects actually inherit from nsWrapperCache?  If not, then passing null is the right thing to do.
They don't inherit from nsWrapperCache, but why write null as xpc_qsGetWrapperCache(resultInterface) when you can write it as NULL?
Probably because it just expanded out codegened worker code...

I wouldn't worry too much about this; this stuff is on the short-list for new-bindings.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.