722168 - convert mailnews/extensions/offline-startup/js/offlineStartup.js to Services.jsm

Status: RESOLVED FIXED

(MailNews Core :: Networking, defect)

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 592516 [details] [diff] [review]
patch

Review of attachment 592516 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/extensions/offline-startup/js/offlineStartup.js
@@ +40,4 @@
>  Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
>  
> +const kDebug              = false;
> +const kBundleURI          = "chrome://messenger/locale/offlineStartup.properties";

We only use this in one place, so there's no point in this being a const.

@@ +67,5 @@
>    onProfileStartup: function()
>    {
>      debug("onProfileStartup");
>  
> +    var ioService = Services.io;

Having had a discussion about this, I think we should drop the intermediate variable/alias - it'll be clearer to everyone and javascript should optimise nicely anyway.

Ditto with prefs and promptService

@@ +115,2 @@
>  
>        var bundle = getBundle(kBundleURI);

We should just kill the getBundle function - we don't do that intense checking elsewhere, and if getting the string bundle is failing, then we've got automation issues somewhere as it should have been picked up.

Comment 3

[:aceman]

Attachment: patch v2

Fixes nits.

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/d4652eaa1a30