722233 - [fi] Accesskey clash in the saved passwords manager

Status: VERIFIED FIXED

(Mozilla Localizations :: fi / Finnish, defect)

Description

[H Jalonen]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912

Steps to reproduce:

1. Open up the saved passwords manager
2. Try to close the window by using keyboard
3. Click the show passwords toggle button
4. Fail at step 2 again


Actual results:

Accesskey for close button "_S_ulje" doesn't work because the same accesskey is used for the show passwords button "Näytä _s_alasanat". Click the show passwords toggle button and notice that the accesskey for close still doesn't work because now it clashes with the new hide passwords label "Piilota _s_alasanat"

As a slightly related side note: unlike all the other similar windows in Firefox, this window cannot be closed by pressing the esc key either (case for another bug if not already filed).


Expected results:

As "S" is commonly used as an accesskey for "Sulje" in the Finnish translation so it should be possible to close the window using the accesskey "S" and the accesskeys for "Näytä salasanat" and "Piilota salasanat" should be changed.

Accesskey string for the show/hide password toggle button are in passwordmgr/passwordmgr.properties line 69 hidePasswordsAccessKey=s and line 71 showPasswordsAccessKey=s

Accesskey string for the close button is in passwordmgr/passwordManager.dtd line 44 <!ENTITY closebutton.accesskey "S">

"Näytä salasanat" could use "N" as the accesskey, however "Piilota salasanat" is trickier since it can't use "P" as it is used for "Poista" and narrow width makes "i" and "l" bad accesskeys (also the Finnish translation for the Saved Password Editor seems to use accesskey "l" for "Kloonaa").

This bug may not affect Macintosh version because a quick peek at the code hinted that it doesn't have a separate close button in the saved passwords manager.

Comment 1

[Ville Pohjanheimo (inactive)]

Thanks for the throughout bug report. Fixed on Aurora by using accesskey t for both show & hide passwords (rev b380cdf522f2). Isn't a nice and wide accesskey, but toggling is easy.