722252 - Add-ons Manager: Extensions without icon get displayed with the icon of the previous extension viewed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Wladimir Palant]

Attachment: Screenshot

See screenshot - that's the details view for the Extensions Auto-Installer, yet it shows the icon of Adblock Plus. To get there I first opened the details view for Adblock Plus, then went back and opened the details view for Extensions Auto-Installer. Extensions Auto-Installer doesn't have an icon, so apparently whichever icon was displayed last simply stays there.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

addon.iconURL is null in this case, but setAttribute("src", null) has no effect, and neither does setAttribute("src", "").  Instead we need to call removeAttribute.

Comment 2

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/930014e7965c

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/930014e7965c

Comment 4

[Paul Feher]

Nightly Fennec 13.0a1 (2012-02-01)
Device: HTC Desire Z
OS: Android 2.3.3

The proper icon is displayed for all add-ons in detail view if there is no icon the icon field stays empty.

Comment 5

[Rika Pi]

Fennec 28.0b4
OS: Android 4.2.2

Addons not from AMO still have this problem if addon has no icon.

ex:
to Replicate bug:

download an addon from outside AMO that does not have an icon 
(ex: http://mozilla.github.io/shumway/extension/firefox/shumway.xpi)
after downloading and installing go to addons page
tap on an addon with an icon
go out of detail view
tap the addon that has no icon and does not come from AMO

Expected result:
for no icon to show when addon has no icon

Actual result:
icon of last addon view with an icon is shown

Comment 6

[Rika Pi]

Attachment: icon of last addon is shown

Comment 7

[Aaron Train [:aaronmt]]

Please open a new bug.