Closed Bug 722426 Opened 11 years ago Closed 11 years ago

Unnecessary android permission WRITE_SECURE_SETTINGS

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P1)

ARM
Android
defect

Tracking

(firefox12 verified)

VERIFIED FIXED
Tracking Status
firefox12 --- verified

People

(Reporter: dchanm+bugzilla, Assigned: nalexander)

References

Details

The sync manifest requests WRITE_SECURE_SETTINGS [1]. This permission is only granted to system/firmware applications. [2]

Removing the permission should have no ill-effects on the application.


[1] - https://github.com/mozilla-services/android-sync/blob/master/manifests/SyncAndroidManifest_permissions.xml.in#L8
[2] - http://developer.android.com/reference/android/provider/Settings.Secure.html
Blocks: 722485
Assignee: nobody → nalexander
Fixed in develop:

https://github.com/mozilla-services/android-sync/commit/f6d048f1a157e6597dfd1a6559aa17e1c3bf053f
Blocks: 720934
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 723230
Tested by:

1. hg clone m-c
2. git clone android-sync
3. apply patch to android-sync
4. code drop from android-sync as per android-sync/README
5. verify mobile/android/sync/manifests/SyncAndroidManifest_permissions.xml.in does not have WRITE_SECURE_SETTINGS
6. build m-c
7. verify fennec/Android Sync not installed on Android emulator
8. install fennec on Android emulator
9. run Android Sync on emulator; verify JPAKE code shown
10. run FF nightly in fresh test profile
11. Pair a Device in FF with JPAKE code shown in emulator
12. verify account appears in Android Sync
Priority: -- → P1
verified with Aurora nightly of 20120207
Status: RESOLVED → VERIFIED
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.