Closed Bug 722470 Opened 13 years ago Closed 11 years ago

Untangle AndroidBrowserRepositoryTest

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P4)

ARM
Android
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rnewman, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

As we introduce more and more session-aware methods, our current tests are being exposed as brittle.

For example, I just had to introduce storeManyRunnable() to perform a sequence of stores, because sequential storeRunnable() calls were trampling each other -- each sets its own delegate, and they race, leading to callbacks hitting the wrong delegate.

storeRunnable() also issues storeDone(), which means you can't issue subsequent stores.

Transactional storing (Bug 709348) leaves us with tests that violate our own API -- they store a record and attempt to retrieve it within the same session, which we are explicitly trying to avoid.

I've worked around this by having the test classes override the transactional tracking, but this is going to leave us with a test ghetto in which a large slab of our functionality is tested by tangled code that doesn't run the way it will in the real world. The right solution is for a batch of stores and the subsequent fetch to take place in different sessions, but that'll require chopping up a lot of test code.

This bug is for that.
Priority: -- → P4
Depends on: 732114
Product: Mozilla Services → Android Background Services
We're not going to fix this, so I'm re-using this ticket to test some bugzilla integration code.
Attachment #756177 - Attachment is obsolete: true
Attachment #756177 - Flags: feedback?(test)
Attachment #756179 - Flags: feedback?(nalexander)
Attachment #756179 - Attachment is obsolete: true
Attachment #756179 - Flags: feedback?(nalexander)
Attachment #756187 - Flags: superreview?(nalexander)
Attachment #756187 - Flags: review?(test)
Attachment #756187 - Flags: review?(nalexander)
Attachment #756187 - Flags: feedback?(test)
Attachment #756187 - Flags: feedback?(nalexander)
rnewman doesn't like bugspam and we've addressed this ticket in different ways, so closing.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Attachment #756187 - Flags: superreview?(nalexander)
Attachment #756187 - Flags: review?(test)
Attachment #756187 - Flags: review?(nalexander)
Attachment #756187 - Flags: feedback?(test)
Attachment #756187 - Flags: feedback?(nalexander)
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: