722494 - add 10.7 build things graphserver

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: add 10.7 build machines to graphs db

Need to add 10.7 build machines to graph server.  I am using the same OS ID as the Talos machines, let me know if this is a problem.  I generated this patch using the following python:

for bt in ['', '_leak_test']:
    for branch in ['tracemonkey', 'places', 'electrolysis', 'maple', 'cedar', 'birch', 'graphics', 'jaegermonkey', 'build-system', 'services-central', 'devtools', 'mozilla-central', 'mozilla-beta', 'mozilla-aurora', 'fx-team', 'alder', 'holly', 'larch', 'ux', 'ionmonkey', 'profiling']:
        print 'insert into machines values (NULL,22,0,NULL,"OS_X_10.7_%s%s",1,unix_timestamp());' % (branch, bt)

Comment 1

[Chris AtLee [:catlee]]

Comment on attachment 592864 [details]
add 10.7 build machines to graphs db

lgtm. this is the first time we're sharing the os_id between a builder and tester, but I think that's ok. maybe poke rhelmer to be sure.

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 592864 [details]
add 10.7 build machines to graphs db

Rob, any thoughts on sharing the os_id between the 'builder' pseudo-machines and the test machines?

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 592864 [details]
add 10.7 build machines to graphs db

Sorry for the delay, slipped through the cracks.

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to John Ford [:jhford] from comment #2)
> Comment on attachment 592864 [details]
> add 10.7 build machines to graphs db
> 
> Rob, any thoughts on sharing the os_id between the 'builder' pseudo-machines
> and the test machines?

From a quick look at the code I don't think it'll be a problem, but we can try on stage first if you want to make sure (shouldn't be hard to back out if not).

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Robert Helmer [:rhelmer] from comment #4)
> (In reply to John Ford [:jhford] from comment #2)
> > Comment on attachment 592864 [details]
> > add 10.7 build machines to graphs db
> > 
> > Rob, any thoughts on sharing the os_id between the 'builder' pseudo-machines
> > and the test machines?
> 
> From a quick look at the code I don't think it'll be a problem, but we can
> try on stage first if you want to make sure (shouldn't be hard to back out
> if not).

I've been running this on stage for a while so there should be data to validate.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: updated to use the 32-bit and 64-bit platforms

If this looks OK, can you please run this on staging graphserver?

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 599246 [details] [diff] [review]
updated to use the 32-bit and 64-bit platforms

Chris is on vacation.

Aki, I am adding 32-bit and 64-bit machine names so that things are clear and explicit