Closed
Bug 722524
Opened 12 years ago
Closed 12 years ago
JPakeCrypto.java checkZkp off by one
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla13
People
(Reporter: dchanm+bugzilla, Assigned: nalexander)
References
Details
(Whiteboard: [qa-])
The BigInteger comparison at [1] doesn't agree with the comment
if (gx.compareTo(BigInteger.ZERO) < 1) {// g^x > 1
gx.compareTo(BigInteger.ZERO) < 1 is true if gx <= 0 . Assuming the comment is correct, the comparison should be against BigInteger.ONE
[1] - https://github.com/mozilla-services/android-sync/blob/master/src/main/java/org/mozilla/gecko/sync/jpake/JPakeCrypto.java#L245
|
Reporter | |
Comment 1•12 years ago
|
||
Corrected link https://github.com/mozilla-services/android-sync/blob/develop/src/main/java/org/mozilla/gecko/sync/jpake/JPakeCrypto.java#L245
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → nalexander
Priority: -- → P1
|
||
Comment 2•12 years ago
|
||
develop: https://github.com/mozilla-services/android-sync/commit/4634a9b5583c023baab35dfd8fc053053164e44f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/74b64932c2f7
Target Milestone: --- → mozilla13
|
||
Updated•12 years ago
|
Whiteboard: [qa-]
|
||
Updated•11 years ago
|
Product: Mozilla Services → Android Background Services
|
||
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
|
||
Updated•5 years ago
|
Group: cloud-services-security
|
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•