Closed
Bug 722578
Opened 14 years ago
Closed 14 years ago
mozprofile deletes all of user.js
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
Attachments
(1 file)
|
7.41 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
We blow away all preferences in a hard coded user.js (see also bug 721174):
https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/profile.py#L193
If we had working tests I would fix this and add a test, but we don't.
|
Reporter | |
Comment 1•14 years ago
|
||
Attachment #592961 -
Flags: review?(mcote)
|
|
Reporter | |
Updated•14 years ago
|
Attachment #592961 -
Flags: review?(mcote) → review?(wlachance)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 592961 [details] [diff] [review]
fix this and add a test
To be thorough, I would like to see another unit test which calls set_preferences multiple times, so we can make sure that the cleaning code works properly.
Aside from that, looks good!
--
+ # prefs files written to
+ self.written_prefs = set()
+
+ # our magic markers
+ self.delimeters = ('#MozRunner Prefs Start', '#MozRunner Prefs End')
+
+
NIT: Did you want two lines of whitespace here?
Attachment #592961 -
Flags: review?(wlachance) → review+
|
|
Reporter | |
Comment 3•14 years ago
|
||
pushed: https://github.com/mozilla/mozbase/commit/c92257e616f2f68fbdac72c051f10c7f9a85b5d0
> NIT: Did you want two lines of whitespace here?
Nope, removed on checkin
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•