72261 - Missing NSPR_API in primpl.h

Status: VERIFIED FIXED

(NSPR :: NSPR, defect)

Description

[Mike Kaply [:mkaply]]

A number of the functions in primpl.h are missing NSPR_API.

I'll attach a diff.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Missing NSPR_APIs in primpl.h

Comment 2

[Mike Kaply [:mkaply]]

Sorry for the spam, attaching to the meta bug.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Remove PR_IMPLEMENTs from OS/2

Comment 4

[Mike Kaply [:mkaply]]

I got this totally wrong.

The problem is that OS/2 put PR_IMPLEMENTs in its files when it shouldn't have.

These are not supposed to be exported functions.

I've attached a diff for this.

There are other platforms that have this problem as well.

The only PR_IMPLEMENT that should be in md/platform directories is PR_Now since 
it is implemented in the actual platform directory.

I'm looking to get this OS/2 only change checked in. Thanks.

Comment 5

[larryh (gone)]

Checked in parts on NSPRPUB_CLIENT_BRANCH

cvs commit -m"Bugzilla: 72261. fix linking problem" pr/src/md/os2/os2cv.c
Checking in pr/src/md/os2/os2cv.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2cv.c,v  <--  os2cv.c
new revision: 3.3.72.1; previous revision: 3.3
done
cvs commit -m"Bugzilla: 72261. fix linking problem" pr/src/md/os2/os2inrval.c
Checking in pr/src/md/os2/os2inrval.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2inrval.c,v  <--  os2inrval.c
new revision: 3.3.72.1; previous revision: 3.3
done
cvs commit -m"Bugzilla: 72261. fix linking problem" pr/src/md/os2/os2misc.c
Checking in pr/src/md/os2/os2misc.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2misc.c,v  <--  os2misc.c
new revision: 3.6.18.1; previous revision: 3.6
done
cvs commit -m"Bugzilla: 72261. fix linking problem" pr/src/md/os2/os2sem.c
Checking in pr/src/md/os2/os2sem.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2sem.c,v  <--  os2sem.c
new revision: 3.2.72.1; previous revision: 3.2
done
cvs commit -m"Bugzilla: 72261. fix linking problem" pr/src/md/os2/os2thred.c
Checking in pr/src/md/os2/os2thred.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2thred.c,v  <--  os2thred.c
new revision: 3.6.18.1; previous revision: 3.6
done

Comment 6

[larryh (gone)]

Refit patch and applied to the tip of tree.

cvs commit -m"bugzilla: 72261. fix linking problems" pr/src/md/os2/os2cv.c
Checking in pr/src/md/os2/os2cv.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2cv.c,v  <--  os2cv.c
new revision: 3.6; previous revision: 3.5
done
cvs commit -m"bugzilla: 72261. fix linking problems" pr/src/md/os2/os2inrval.c
Checking in pr/src/md/os2/os2inrval.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2inrval.c,v  <--  os2inrval.c
new revision: 3.6; previous revision: 3.5
done
cvs commit -m"bugzilla: 72261. fix linking problems" pr/src/md/os2/os2misc.c
Checking in pr/src/md/os2/os2misc.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2misc.c,v  <--  os2misc.c
new revision: 3.10; previous revision: 3.9
done
cvs commit -m"bugzilla: 72261. fix linking problems" pr/src/md/os2/os2sem.c
Checking in pr/src/md/os2/os2sem.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2sem.c,v  <--  os2sem.c
new revision: 3.5; previous revision: 3.4
done
cvs commit -m"bugzilla: 72261. fix linking problems" pr/src/md/os2/os2thred.c
Checking in pr/src/md/os2/os2thred.c;
/cvsroot/mozilla/nsprpub/pr/src/md/os2/os2thred.c,v  <--  os2thred.c
new revision: 3.9; previous revision: 3.8
done

Comment 7

[larryh (gone)]

Mike,
Please checkout or merge the changes and build on both NSPRPUB_CLIENT_BRANCH and 
the tip. Make sure I got the patches applied OK.

Comment 8

[larryh (gone)]

marking fixed, absent objections.

Comment 9

[Mike Kaply [:mkaply]]

Code change - this is fixed