722627 - NativeWindow.contextmenus.remove creates a JS exception

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

NativeWindow.contextmenus.remove sets the item stored in the object map to null. When we attempt to show the context menu, we iterate over the object map and try to use the objects. This causes a JS exception and the menu is not displayed.

Instead of setting the item to null, we should delete it from the object map. This patch fixes the problem.

The add-on here has a "Copy Link" context menu. if you disable/enable the add-on the menbu will fail to display when long tapping on a link. The patch makes it work.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 592999 [details] [diff] [review]
patch

Review of attachment 592999 [details] [diff] [review]:
-----------------------------------------------------------------

DOH!

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2832d09301f

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/69ca6e6c57ea

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 592999 [details] [diff] [review]
patch

Regression caused by (bug #): bug 695460
User impact if declined: extensions won't uninstall correctly among other problems they might have
Testing completed (on m-c, etc.): on mc for a few days. tested with the sample addon mfinkle built
Risk to taking this patch (and alternatives if risky): very low. mobile only. bug fix.
String changes made by this patch: none.

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 592999 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c2832d09301f

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4e3a872ac00d

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0cb46e206f9e

Comment 9

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-07)
20120207031136
http://hg.mozilla.org/mozilla-central/rev/b077059c575a
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3