open a new tab from Panorama view should reference gWindow.BROWSER_NEW_TAB_URL

VERIFIED FIXED in Firefox 13

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: teramako, Assigned: teramako)

Tracking

12 Branch
Firefox 13
Dependency tree / graph

Details

(Whiteboard: [qa!])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 593046 [details] [diff] [review]
panorama_groupItem_newtab.patch

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0a1) Gecko/20120130 Firefox/12.0a1
Build ID: 20120130031142

Steps to reproduce:

1. open about:config
2. edit "browser.newtab.url" to "about:newtab"
3. restart Firefox
4. open Panorama
5. create new group and click the group
6. then opens about:blank page

GroupItem.prototype.newTab method should open "gWindow. BROWSER_NEW_TAB_URL" if the arguments are omitted or blank.
(Assignee)

Updated

5 years ago
Component: Untriaged → Panorama
Depends on: 455553
OS: Windows XP → All
Hardware: x86 → All

Updated

5 years ago
QA Contact: untriaged → panorama

Updated

5 years ago
Attachment #593046 - Attachment is patch: true

Updated

5 years ago
Attachment #593046 - Flags: review?(ttaubert)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 593046 [details] [diff] [review]
panorama_groupItem_newtab.patch

Review of attachment 593046 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for your patch! Can you please package this so that I can check it in?
Attachment #593046 - Flags: review?(ttaubert) → review+
Duplicate of this bug: 617781
Blocks: 648286
(Assignee)

Comment 3

5 years ago
(In reply to Tim Taubert [:ttaubert] from comment #1)
> Comment on attachment 593046 [details] [diff] [review]
> panorama_groupItem_newtab.patch
> 
> Review of attachment 593046 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, thanks for your patch! Can you please package this so that I can
> check it in?

I don't have the privilege to check in, so could you do ?
And I'm not familiar with mercurial, so I don't know how to package my patch :(
Ok, no problem. I'll do it.
Assignee: nobody → teramako
Status: NEW → ASSIGNED
Summary: open a new tab from Panorama view should reference gWindow. BROWSER_NEW_TAB_URL → open a new tab from Panorama view should reference gWindow.BROWSER_NEW_TAB_URL
Created attachment 593820 [details] [diff] [review]
patch v1

There was a test that needed a fix and another one threw an error, sorry for not catching this earlier.
Attachment #593046 - Attachment is obsolete: true
Attachment #593820 - Flags: review?(dietrich)
Created attachment 593831 [details] [diff] [review]
patch v2

Uses now a not so hacky workaround for the 'gPage is not defined' error.
Attachment #593820 - Attachment is obsolete: true
Attachment #593820 - Flags: review?(dietrich)
Attachment #593831 - Flags: review?(dietrich)
What exactly does gPage have to do with this bug?
Using 'about:newtab' as the new tab page leads to a strange error while running tabview tests. gPage seems undefined although newTab.js is loaded right before. This is probably caused because we're quickly opening and closing tabs. We can simply fix this by combining those two scripts.
Attachment #593831 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/integration/fx-team/rev/5be3a6666dd4
Target Milestone: --- → Firefox 13
https://hg.mozilla.org/mozilla-central/rev/5be3a6666dd4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/20120227 Firefox/13.0a1
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120227 Firefox/13.0a1
Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20120227 Firefox/13.0a1

Verified on Firefox 13, latest Nightly. The new tab page is displayed when selecting an empty tab group.
Status: RESOLVED → VERIFIED
Whiteboard: [qa!]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.