Closed Bug 722775 Opened 8 years ago Closed 8 years ago

rm sameGroupAs

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: luke, Assigned: luke)

References

Details

Attachments

(1 file)

Attached patch rmSplinter Review
Bug 650353 plans to make compartments and globals 1:1 (for a multitude of reasons).  Unfortunately, this makes implementing the sameGroupAs optimization impossible.  Fortunately, bug 720753 will make JSCompartment a lot slimmer so the optimization shouldn't matter as much.  The attached patch essentially backs out bug 677294.  There are no uses of sameGroupAs on mozilla-central, only the addons-sdk, so cc'ing some jetpack folks.
Attachment #593150 - Flags: review?(mrbkap)
Comment on attachment 593150 [details] [diff] [review]
rm

Is it worth warning in the error console to make it easier to find uses of sameGroupAs.

The Jetpack folks knew that this was coming, along with the slimmer compartments, so hopefully this shouldn't be controversial. That said, we probably shouldn't land this until we actually do slim down compartments.
Attachment #593150 - Flags: review?(mrbkap) → review+
Assignee: nobody → luke
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/2654f79e0e84
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.