Closed Bug 722790 Opened 13 years ago Closed 13 years ago

We bumped Mac to the wrong platform

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: armenzg)

Details

Attachments

(1 file)

It seems that update-verify-bump.pl has changed our platform for Mac from Darwin_x86-gcc3-u-ppc-i386 to Darwin_Universal-gcc3. It seems we do a string comparison [2], and it fails because '10.0' is less than '4.0' as a string. > if ($majorMode and $product eq 'firefox' and $appVersion ge '4.0') { This was caught in our update verify step. [1] http://hg.mozilla.org/build/tools/rev/0d04136ee281 [2] http://hg.mozilla.org/build/tools/file/7b8d8c6168d3/release/update-verify-bump.pl#l242
Assignee: nobody → armenzg
Status: NEW → ASSIGNED
Attachment #593165 - Flags: review?(bhearsum)
Armens-MacBook-Air:~ armenzg$ cat test.pl $temp = '10.0'; $temp2 = '9.0'; $temp3 = '3.0'; if ($temp > '4.0') { print "Good\n"; } if ($temp2 > '4.0') { print "Good\n"; } if ($temp3 > '4.0') { print "Bad\n"; } Armens-MacBook-Air:~ armenzg$ perl test.pl Good Good
Comment on attachment 593165 [details] [diff] [review] one-off fix plus long term fix Review of attachment 593165 [details] [diff] [review]: ----------------------------------------------------------------- http://www.perlhome.com/perloperators/ agrees that > is the correct thing to use here. Thanks Armen!
Attachment #593165 - Flags: review?(bhearsum) → review+
Comment on attachment 593165 [details] [diff] [review] one-off fix plus long term fix http://hg.mozilla.org/build/tools/rev/df7cefe31018 I had to tag it: > hg tag -r df7cefe31018 -f FIREFOX_10_0_RELEASE_RUNTIME I would have assume we would use the FIREFOX_3_6_26_RELEASE_RUNTIME bhearsum, do you think that is a bug?
Attachment #593165 - Flags: checked-in+
(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #4) > Comment on attachment 593165 [details] [diff] [review] > one-off fix plus long term fix > > http://hg.mozilla.org/build/tools/rev/df7cefe31018 > > I had to tag it: > > hg tag -r df7cefe31018 -f FIREFOX_10_0_RELEASE_RUNTIME > > I would have assume we would use the FIREFOX_3_6_26_RELEASE_RUNTIME > > bhearsum, do you think that is a bug? Correct.
(In reply to Ben Hearsum [:bhearsum] from comment #5) > (In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #4) > > Comment on attachment 593165 [details] [diff] [review] > > one-off fix plus long term fix > > > > http://hg.mozilla.org/build/tools/rev/df7cefe31018 > > > > I had to tag it: > > > hg tag -r df7cefe31018 -f FIREFOX_10_0_RELEASE_RUNTIME > > > > I would have assume we would use the FIREFOX_3_6_26_RELEASE_RUNTIME > > > > bhearsum, do you think that is a bug? > > Correct. Filed bug 722860 to correct the incorrect tag usage.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: