If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

results.py should be callable with actual browser dump data

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Jeff Hammel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [SfN])

(Reporter)

Description

6 years ago
As part of Signal from Noise, https://wiki.mozilla.org/Auto-tools/Projects/Signal_From_Noise , we will often want to examine the data from actual TBPL logs.  
http://hg.mozilla.org/build/talos/file/9c1b3addb9ee/talos/results.py has much of the parsing and storing stuff that we want.  However, we should augment this to actually do what we want:

- we'll need to parse things a bit better. TBPL logs have more than just the Talos results in them; http://hg.mozilla.org/build/talos/file/9c1b3addb9ee/talos/ttest.py has the parsing code in it but really this is a. the wrong place to do it; and b. you still get out something you have to further parse. ideally this would be restructured

- we'll want a way to explore the data; maybe just sticking a pdb in is sufficient

other ideas welcome


Example diff (toy):
(talos)│hg diff results.py 
diff --git a/talos/results.py b/talos/results.py
--- a/talos/results.py
+++ b/talos/results.py
@@ -69,8 +69,22 @@ class PageloaderResults(object):
     def mean(self):
         return self.value('mean')
 
     def max(self):
         return self.value('max')
 
     def min(self):
         return self.value('min')
+
+if __name__ == '__main__':
+    import sys
+    string_high = """
+|0;big-optimizable-group-opacity-2500.svg;123.5;354.25;92;1130;147;1130;1078;92;100
+|1;small-group-opacity-2500.svg;109;2333.25;103;9247;103;9012;9247;111;107
+"""
+    string_low = """
+|0;big-optimizable-group-opacity-2500.svg;119;353.75;91;1132;139;1132;1086;91;99
+|1;small-group-opacity-2500.svg;108;113;103;9116;103;133;9116;108;108
+"""
+    big = PageloaderResults(string_high)
+    small = PageloaderResults(string_low)
+    import pdb; pdb.set_trace()
(Reporter)

Updated

5 years ago
Depends on: 755527
(Reporter)

Comment 1

5 years ago
fixed with bug 755527
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.