723029 - Crash in mozilla::storage::Service::UpdateQutoaInformationForFile @ `anonymous namespace''::xOpen

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect)

Description

[Scoobidiver (away)]

70% of crashes happen within one minute.

Signature 	`anonymous namespace''::xOpen(sqlite3_vfs*, char const*, sqlite3_file*, int, int*) More Reports Search
UUID	33991ed1-d358-445e-a265-775392120201
Date Processed	2012-02-01 09:22:13
Uptime	3
Last Crash	7 seconds before submission
Install Age	14.5 hours since version was first installed.
Install Time	2012-01-31 19:51:04
Product	Firefox
Version	10.0
Build ID	20120129021758
Release Channel	release
OS	Windows NT
OS Version	5.1.2600 Service Pack 3
Build Architecture	x86
Build Architecture Info	GenuineIntel family 6 model 37 stepping 2
Crash Reason	EXCEPTION_ACCESS_VIOLATION_READ
Crash Address	0xe
App Notes 	
AdapterVendorID: 1002, AdapterDeviceID: 68f9, AdapterSubsysID: 20081787, AdapterDriverVersion: 8.753.0.0
D3D10 Layers? D3D10 Layers-
EMCheckCompatibility	True

Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	`anonymous namespace'::xOpen 	storage/src/TelemetryVFS.cpp:330
1 	xul.dll 	quotaOpen 	db/sqlite3/src/test_quota.c:373
2 	xul.dll 	sqlite3_quota_file 	db/sqlite3/src/test_quota.c:830
3 	xul.dll 	mozilla::storage::Service::UpdateQutoaInformationForFile 	storage/src/mozStorageService.cpp:721
4 	xul.dll 	mozilla::dom::indexedDB::IndexedDatabaseManager::EnsureQuotaManagementForDirectory 	dom/indexeddb/IndexedDatabaseManager.cpp:653
5 	xul.dll 	mozilla::dom::indexedDB::OpenDatabaseHelper::DoDatabaseWork 	dom/indexeddb/OpenDatabaseHelper.cpp:749
6 	xul.dll 	mozilla::dom::indexedDB::OpenDatabaseHelper::Run 	dom/indexeddb/OpenDatabaseHelper.cpp:988
7 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:631
8 	xul.dll 	nsThreadStartupEvent::Run 	xpcom/threads/nsThread.cpp:201
9 	nspr4.dll 	_PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c:426
10 	nspr4.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c:122
11 	msvcr80.dll 	_callthreadstartex 	f:\\sp\\vctools\\crt_bld\\self_x86\\crt\\src\\threadex.c:348
12 	msvcr80.dll 	_threadstartex 	f:\\sp\\vctools\\crt_bld\\self_x86\\crt\\src\\threadex.c:326
13 	kernel32.dll 	BaseThreadStart 	

More reports at:
https://crash-stats.mozilla.com/report/list?signature=%60anonymous%20namespace%27%27%3A%3AxOpen%28sqlite3_vfs*%2C%20char%20const*%2C%20sqlite3_file*%2C%20int%2C%20int*%29

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ccing bent who better knows the quota management code

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

See comment 6 and the TelemetryVFS hunk in Bug 702292.

Marco, can you land that hunk and get approval for relevant branches?  It has r=taras.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

sorry but I can't follow all that happened in that bug, may I get a proper patch attached here, will be easier for everyone, especially for approvals.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

setting up according on existence of a patch somewhere in Bug 702292.

Comment 5

[Scoobidiver (away)]

85% of crashes happen within one minute. Does this qualify that crash for the startupcrash keyword?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'm moving across the country this weekend, so I would appreciate someone else landing this.

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Scoobidiver from comment #5)
> 85% of crashes happen within one minute. Does this qualify that crash for
> the startupcrash keyword?

I removed the startupcrash annotation because this is triggered by webpages using IndexedDB (which hits the underlying bug in TelemetryVFS.cpp).  This is only a crash at startup if users are unfortunate enough to have a page using IndexedDB load at startup.

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/543de57b25f3

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/543de57b25f3

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 594436 [details] [diff] [review]
Patch

[Triage Comment]
Top startup crasher - approved for Beta 11 and Aurora 12.

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c9fb84b0331e
https://hg.mozilla.org/releases/mozilla-beta/rev/618a6670c5ed

Comment 13

[Trif Andrei-Alin[:AlinT]]

How can i verify the fixing of this bug?
Any info would be appreciated.

Comment 14

[u279076]

Kyle, are there any correlations with this crash that QA can try testing to help verify this fix?

Comment 15

[Alex Keybl [:akeybl]]

Please land on mozilla-esr10 as soon as possible. For more information on the landing process, please see https://wiki.mozilla.org/Release_Management/ESR_Landing_Process

Comment 16

[Mihaela Velimiroviciu (:mihaelav)]

I have checked the crash reports and found 3 crashes with this signature ( on builds newer than the fixes:
https://crash-stats.mozilla.com/report/index/e11b4ad3-0465-437c-b92b-564212120220
https://crash-stats.mozilla.com/report/index/506d40e6-7bae-4631-a401-d77082120219
https://crash-stats.mozilla.com/report/index/8b4d3c47-cb0b-4892-b1e7-d122e2120215

Should this be reopened?
Thanks!

Comment 17

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

those don't come from UpdateQuotaInformationForFile and look a bit different.
The crash is one line earlier too, so I'd file a separate bug.

Comment 18

[Mihaela Velimiroviciu (:mihaelav)]

(In reply to Marco Bonardo [:mak] from comment #17)
> those don't come from UpdateQuotaInformationForFile and look a bit different.
> The crash is one line earlier too, so I'd file a separate bug.
Bug 731171 was logged for the crashes from comment #16.

Is there anything else that can be done in order to verify this bug?
Thanks!

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 594436 [details] [diff] [review]
Patch

[Triage comment]
This patch is being tracked for the upcoming esr 10.0.3 release and needs to be landed today preferably, or tomorrow if need be.  Let me know if there are any concerns about getting it landed in time.  See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for details.

Comment 20

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-esr10/rev/a80721e1b2d2

Comment 21

[u279076]

No reported crashes recently for any Firefox version. Marking VERIFIED.

Comment 22

[u279076]

Not seeing any ESR related crashes post-fix either.