Closed
Bug 723084
Opened 12 years ago
Closed 12 years ago
JavaScript Error: "this.browser is null" {file: "chrome://browser/content/browser.js" line: 2117}
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox11 verified, firefox12 verified, firefox13 verified)
VERIFIED
FIXED
Firefox 13
People
(Reporter: martijn.martijn, Assigned: mbrubeck)
Details
(Keywords: testcase, Whiteboard: [has patch])
Attachments
(3 files)
|
226 bytes,
text/html
|
Details | |
|
30.12 KB,
text/plain
|
Details | |
|
1.25 KB,
patch
|
bnicholson
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
See testcase, steps to reproduce:
- Tap on "windowopenbuttononclick" button, a window opens and then closes
- Reload the page
Expected result:
- No js errors in logcat
Actual result:
- This error in logcat: E/GeckoConsole(4572): [JavaScript Error: "this.browser is null" {file: "chrome://browser/content/browser.js" line: 2117}]
Tested on the LG Optimus Black, Android 2.2.2.
Note that tapping multiple times on the "windowopenbuttononclick" button and then reloading results in multiple js errors in logcat.
|
Reporter | |
Comment 1•12 years ago
|
||
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mbrubeck
|
|
Assignee | |
Comment 2•12 years ago
|
||
We add a "document-shown" observer when a Tab is created, but we didn't remove it when the Tab was destroyed. This patch fixes the bug, and might also prevent us from leaking memory as tabs are closed.
Attachment #593531 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [has patch]
|
||
Updated•12 years ago
|
Attachment #593531 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d711befe9037
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 593531 [details] [diff] [review] patch [Approval Request Comment] Low-risk trivial Android-only bug and memory leak fix.
Attachment #593531 -
Flags: approval-mozilla-beta?
Attachment #593531 -
Flags: approval-mozilla-aurora?
|
||
Comment 5•12 years ago
|
||
Comment on attachment 593531 [details] [diff] [review] patch [Triage Comment] Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593531 -
Flags: approval-mozilla-beta?
Attachment #593531 -
Flags: approval-mozilla-beta+
Attachment #593531 -
Flags: approval-mozilla-aurora?
Attachment #593531 -
Flags: approval-mozilla-aurora+
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d711befe9037
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8edb8d421bef https://hg.mozilla.org/releases/mozilla-beta/rev/da8748056d6d
|
||
Comment 8•12 years ago
|
||
No such error in log. Verified fixed on build: Firefox 11 (tinderbox build): 1328482809/ 05-Feb-2012 16:26 Firefox 12: Firefox 12.0a2 (2012-02-05) Firefox 13: Firefox 13.0a1 (2012-02-05) Device: LG Optimus 2X (Android 2.2.2)
Status: RESOLVED → VERIFIED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•