723112 - attachment reminder bar is too tall

Status: RESOLVED FIXED

Description

[Andreas Nilsson (:andreasn)]

Created attachment 593446 [details]
screenshot of the issue

Discovered during Bigfiles testing that the attachment reminder bar on the Mac is a bit too tall. This is mainly due to the big icon we're using there. This also affects the bar where bigfiles asks you if you want to convert the file.

Comment 1

[Andreas Nilsson (:andreasn)]

Created attachment 593464 [details] [diff] [review]
patch to fix the issue

Smaller icon, styled in a similar way to the Firefox notification bar icons.

Comment 2

[Andreas Nilsson (:andreasn)]

Created attachment 593472 [details] [diff] [review]
updated patch

Aha, making the icon 16x16 makes it the right size since Firefox just tends to scale their 24x24px icons in the popup bar.

Comment 3

[Andreas Nilsson (:andreasn)]

Created attachment 593473 [details] [diff] [review]
updated patch (again)

bugzilla is funny with me today

Comment 4

[Andreas Nilsson (:andreasn)]

Created attachment 593481 [details]
screenshot of patch in action

and here is how it looks in action

Comment 5

[Mike Conley (:mconley) - Buried in needinfo / review backlog, eating my way out]

Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Review of attachment 593473 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks OK to me.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Yeah.  I worry a little that the new notification will be less visible, but the bright yellow sort of mitigates that fear.  ;)

ui-r=me!

Thanks,
Blake.

Comment 7

[Mark Banner (:standard8) (afk 21 - 30 July)]

Checked in: http://hg.mozilla.org/comm-central/rev/c428aa3c9d71