Status
People
(Reporter: andreasn, Assigned: andreasn)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(3 attachments, 2 obsolete attachments)
28.47 KB,
image/png
|
Details | |
2.52 KB,
patch
|
mconley
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
13.54 KB,
image/png
|
Details |
Created attachment 593446 [details] screenshot of the issue Discovered during Bigfiles testing that the attachment reminder bar on the Mac is a bit too tall. This is mainly due to the big icon we're using there. This also affects the bar where bigfiles asks you if you want to convert the file.
(Assignee) | ||
Comment 1•7 years ago
|
||
Created attachment 593464 [details] [diff] [review] patch to fix the issue Smaller icon, styled in a similar way to the Firefox notification bar icons.
(Assignee) | ||
Comment 2•7 years ago
|
||
Created attachment 593472 [details] [diff] [review] updated patch Aha, making the icon 16x16 makes it the right size since Firefox just tends to scale their 24x24px icons in the popup bar.
Attachment #593464 -
Attachment is obsolete: true
(Assignee) | ||
Comment 3•7 years ago
|
||
Created attachment 593473 [details] [diff] [review] updated patch (again) bugzilla is funny with me today
Attachment #593472 -
Attachment is obsolete: true
(Assignee) | ||
Comment 4•7 years ago
|
||
Created attachment 593481 [details] screenshot of patch in action and here is how it looks in action
(Assignee) | ||
Updated•7 years ago
|
Attachment #593473 -
Flags: ui-review?(bwinton)
Attachment #593473 -
Flags: review?(mconley)
Comment 5•7 years ago
|
||
Comment on attachment 593473 [details] [diff] [review] updated patch (again) Review of attachment 593473 [details] [diff] [review]: ----------------------------------------------------------------- Code looks OK to me.
Attachment #593473 -
Flags: review?(mconley) → review+
Comment 6•7 years ago
|
||
Comment on attachment 593473 [details] [diff] [review] updated patch (again) Yeah. I worry a little that the new notification will be less visible, but the bright yellow sort of mitigates that fear. ;) ui-r=me! Thanks, Blake.
Attachment #593473 -
Flags: ui-review?(bwinton) → ui-review+
(Assignee) | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 7•7 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/c428aa3c9d71
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in
before you can comment on or make changes to this bug.
Description
•