Closed
Bug 723112
Opened 12 years ago
Closed 12 years ago
attachment reminder bar is too tall
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 13.0
People
(Reporter: andreasn, Assigned: andreasn)
Details
Attachments
(3 files, 2 obsolete files)
28.47 KB,
image/png
|
Details | |
2.52 KB,
patch
|
mconley
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
13.54 KB,
image/png
|
Details |
Discovered during Bigfiles testing that the attachment reminder bar on the Mac is a bit too tall. This is mainly due to the big icon we're using there. This also affects the bar where bigfiles asks you if you want to convert the file.
Assignee | ||
Comment 1•12 years ago
|
||
Smaller icon, styled in a similar way to the Firefox notification bar icons.
Assignee | ||
Comment 2•12 years ago
|
||
Aha, making the icon 16x16 makes it the right size since Firefox just tends to scale their 24x24px icons in the popup bar.
Attachment #593464 -
Attachment is obsolete: true
Assignee | ||
Comment 3•12 years ago
|
||
bugzilla is funny with me today
Attachment #593472 -
Attachment is obsolete: true
Assignee | ||
Comment 4•12 years ago
|
||
and here is how it looks in action
Assignee | ||
Updated•12 years ago
|
Attachment #593473 -
Flags: ui-review?(bwinton)
Attachment #593473 -
Flags: review?(mconley)
Comment 5•12 years ago
|
||
Comment on attachment 593473 [details] [diff] [review] updated patch (again) Review of attachment 593473 [details] [diff] [review]: ----------------------------------------------------------------- Code looks OK to me.
Attachment #593473 -
Flags: review?(mconley) → review+
Comment 6•12 years ago
|
||
Comment on attachment 593473 [details] [diff] [review] updated patch (again) Yeah. I worry a little that the new notification will be less visible, but the bright yellow sort of mitigates that fear. ;) ui-r=me! Thanks, Blake.
Attachment #593473 -
Flags: ui-review?(bwinton) → ui-review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 7•12 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/c428aa3c9d71
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in
before you can comment on or make changes to this bug.
Description
•