Closed Bug 723112 Opened 8 years ago Closed 8 years ago

attachment reminder bar is too tall

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 13.0

People

(Reporter: andreasn, Assigned: andreasn)

Details

Attachments

(3 files, 2 obsolete files)

Attached image screenshot of the issue
Discovered during Bigfiles testing that the attachment reminder bar on the Mac is a bit too tall. This is mainly due to the big icon we're using there. This also affects the bar where bigfiles asks you if you want to convert the file.
Attached patch patch to fix the issue (obsolete) — Splinter Review
Smaller icon, styled in a similar way to the Firefox notification bar icons.
Attached patch updated patch (obsolete) — Splinter Review
Aha, making the icon 16x16 makes it the right size since Firefox just tends to scale their 24x24px icons in the popup bar.
Attachment #593464 - Attachment is obsolete: true
bugzilla is funny with me today
Attachment #593472 - Attachment is obsolete: true
and here is how it looks in action
Attachment #593473 - Flags: ui-review?(bwinton)
Attachment #593473 - Flags: review?(mconley)
Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Review of attachment 593473 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks OK to me.
Attachment #593473 - Flags: review?(mconley) → review+
Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Yeah.  I worry a little that the new notification will be less visible, but the bright yellow sort of mitigates that fear.  ;)

ui-r=me!

Thanks,
Blake.
Attachment #593473 - Flags: ui-review?(bwinton) → ui-review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/c428aa3c9d71
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in before you can comment on or make changes to this bug.