attachment reminder bar is too tall

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

unspecified
Thunderbird 13.0
All
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 593446 [details]
screenshot of the issue

Discovered during Bigfiles testing that the attachment reminder bar on the Mac is a bit too tall. This is mainly due to the big icon we're using there. This also affects the bar where bigfiles asks you if you want to convert the file.
(Assignee)

Comment 1

6 years ago
Created attachment 593464 [details] [diff] [review]
patch to fix the issue

Smaller icon, styled in a similar way to the Firefox notification bar icons.
(Assignee)

Comment 2

6 years ago
Created attachment 593472 [details] [diff] [review]
updated patch

Aha, making the icon 16x16 makes it the right size since Firefox just tends to scale their 24x24px icons in the popup bar.
Attachment #593464 - Attachment is obsolete: true
(Assignee)

Comment 3

6 years ago
Created attachment 593473 [details] [diff] [review]
updated patch (again)

bugzilla is funny with me today
Attachment #593472 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
Created attachment 593481 [details]
screenshot of patch in action

and here is how it looks in action
(Assignee)

Updated

6 years ago
Attachment #593473 - Flags: ui-review?(bwinton)
Attachment #593473 - Flags: review?(mconley)
Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Review of attachment 593473 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks OK to me.
Attachment #593473 - Flags: review?(mconley) → review+
Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Yeah.  I worry a little that the new notification will be less visible, but the bright yellow sort of mitigates that fear.  ;)

ui-r=me!

Thanks,
Blake.
Attachment #593473 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/c428aa3c9d71
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
You need to log in before you can comment on or make changes to this bug.