Last Comment Bug 723112 - attachment reminder bar is too tall
: attachment reminder bar is too tall
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All Mac OS X
: -- normal (vote)
: Thunderbird 13.0
Assigned To: Andreas Nilsson (:andreasn)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-01 07:42 PST by Andreas Nilsson (:andreasn)
Modified: 2012-02-15 03:03 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
screenshot of the issue (28.47 KB, image/png)
2012-02-01 07:42 PST, Andreas Nilsson (:andreasn)
no flags Details
patch to fix the issue (2.60 KB, patch)
2012-02-01 08:33 PST, Andreas Nilsson (:andreasn)
no flags Details | Diff | Splinter Review
updated patch (2.52 KB, patch)
2012-02-01 09:00 PST, Andreas Nilsson (:andreasn)
no flags Details | Diff | Splinter Review
updated patch (again) (2.52 KB, patch)
2012-02-01 09:02 PST, Andreas Nilsson (:andreasn)
mconley: review+
bwinton: ui‑review+
Details | Diff | Splinter Review
screenshot of patch in action (13.54 KB, image/png)
2012-02-01 09:21 PST, Andreas Nilsson (:andreasn)
no flags Details

Description Andreas Nilsson (:andreasn) 2012-02-01 07:42:13 PST
Created attachment 593446 [details]
screenshot of the issue

Discovered during Bigfiles testing that the attachment reminder bar on the Mac is a bit too tall. This is mainly due to the big icon we're using there. This also affects the bar where bigfiles asks you if you want to convert the file.
Comment 1 Andreas Nilsson (:andreasn) 2012-02-01 08:33:08 PST
Created attachment 593464 [details] [diff] [review]
patch to fix the issue

Smaller icon, styled in a similar way to the Firefox notification bar icons.
Comment 2 Andreas Nilsson (:andreasn) 2012-02-01 09:00:32 PST
Created attachment 593472 [details] [diff] [review]
updated patch

Aha, making the icon 16x16 makes it the right size since Firefox just tends to scale their 24x24px icons in the popup bar.
Comment 3 Andreas Nilsson (:andreasn) 2012-02-01 09:02:13 PST
Created attachment 593473 [details] [diff] [review]
updated patch (again)

bugzilla is funny with me today
Comment 4 Andreas Nilsson (:andreasn) 2012-02-01 09:21:56 PST
Created attachment 593481 [details]
screenshot of patch in action

and here is how it looks in action
Comment 5 Mike Conley (:mconley) - (Needinfo me!) 2012-02-01 13:03:19 PST
Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Review of attachment 593473 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks OK to me.
Comment 6 Blake Winton (:bwinton) (:☕️) 2012-02-13 17:57:09 PST
Comment on attachment 593473 [details] [diff] [review]
updated patch (again)

Yeah.  I worry a little that the new notification will be less visible, but the bright yellow sort of mitigates that fear.  ;)

ui-r=me!

Thanks,
Blake.
Comment 7 Mark Banner (:standard8) (afk until 26th July) 2012-02-15 03:03:03 PST
Checked in: http://hg.mozilla.org/comm-central/rev/c428aa3c9d71

Note You need to log in before you can comment on or make changes to this bug.