No drawable resources defined for eclair

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

unspecified
Firefox 13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 fixed, fennec11+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 593485 [details] [diff] [review]
patch

all our drawables are drawalbe-[m/h/xh/]dpi-v[8/11/14]. Its that last part, specifying versions, that excludes eclair. The "right" thing to do according to the android docs is to have a complete set of your base resources in res/drawable, res/layout, res/strings etc etc. We're certainly violating that for drawables, not sure about the rest of them.

With this patch I can run fennec on my N1 running eclair
Attachment #593485 - Flags: review?(mark.finkle)
Patch is partly missing
Created attachment 593539 [details] [diff] [review]
patch

not sure what went wrong there
Assignee: nobody → blassey.bugs
Attachment #593485 - Attachment is obsolete: true
Attachment #593485 - Flags: review?(mark.finkle)
Attachment #593539 - Flags: review?(mark.finkle)
Comment on attachment 593539 [details] [diff] [review]
patch

Looks good, but I want Sriram to be aware of this too and look for any issues
Attachment #593539 - Flags: review?(mark.finkle)
Attachment #593539 - Flags: review+
Attachment #593539 - Flags: feedback?(sriram)
Comment on attachment 593539 [details] [diff] [review]
patch

Review of attachment 593539 [details] [diff] [review]:
-----------------------------------------------------------------

The v8 was added thinking that we wouldn't be supporting eclair. I am happy with this change :)
I am not sure if we want LDPI version. If I remember correctly we don't support LDPI.
Attachment #593539 - Flags: feedback?(sriram) → feedback+
(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> Comment on attachment 593539 [details] [diff] [review]
> patch
> 
> Review of attachment 593539 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The v8 was added thinking that we wouldn't be supporting eclair. I am happy
> with this change :)
> I am not sure if we want LDPI version. If I remember correctly we don't
> support LDPI.

we don't, but sync has an LDPI resource.
Probably we need to ask Sync team if they really want those resources (I believe they use eclipse and eclipse created the ldpi folder by default). If they don't want, we can remove it some day. If they want it, we should think of copying low resolution images into drawable-ldpi to make us LDPI devices ready.

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f7a88134a0f7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593539 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
crash on startup on eclair
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #593539 - Flags: approval-mozilla-beta?
Attachment #593539 - Flags: approval-mozilla-aurora?
Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:13.0a1)Gecko/20120203
Firefox/13.0a1 Fennec/13.0a1
Device: Samsung Galaxy S
OS: Android 2.1-update1
status-firefox12: --- → affected
status-firefox13: --- → fixed
Aurora nom?
(In reply to Cristian Nicolae (:xti) from comment #10)
> Aurora nom?

See the patch above. It's question marked already.
(In reply to Aaron Train [:aaronmt] from comment #11)
> (In reply to Cristian Nicolae (:xti) from comment #10)
> > Aurora nom?
> 
> See the patch above. It's question marked already.

Sorry, I just missed it. Thanks
Comment on attachment 593539 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593539 - Flags: approval-mozilla-beta?
Attachment #593539 - Flags: approval-mozilla-beta+
Attachment #593539 - Flags: approval-mozilla-aurora?
Attachment #593539 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/7c4652b0f3b0
status-firefox11: --- → affected
status-firefox12: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/02d946fad4c7
status-firefox11: affected → fixed
You need to log in before you can comment on or make changes to this bug.