Closed
Bug 723151
Opened 12 years ago
Closed 12 years ago
No drawable resources defined for eclair
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox11 fixed, firefox12 fixed, firefox13 fixed, fennec11+)
RESOLVED
FIXED
Firefox 13
People
(Reporter: blassey, Assigned: blassey)
Details
Attachments
(1 file, 1 obsolete file)
41.55 KB,
patch
|
mfinkle
:
review+
sriram
:
feedback+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
all our drawables are drawalbe-[m/h/xh/]dpi-v[8/11/14]. Its that last part, specifying versions, that excludes eclair. The "right" thing to do according to the android docs is to have a complete set of your base resources in res/drawable, res/layout, res/strings etc etc. We're certainly violating that for drawables, not sure about the rest of them. With this patch I can run fennec on my N1 running eclair
Attachment #593485 -
Flags: review?(mark.finkle)
Comment 1•12 years ago
|
||
Patch is partly missing
Assignee | ||
Comment 2•12 years ago
|
||
not sure what went wrong there
Assignee: nobody → blassey.bugs
Attachment #593485 -
Attachment is obsolete: true
Attachment #593485 -
Flags: review?(mark.finkle)
Attachment #593539 -
Flags: review?(mark.finkle)
Comment 3•12 years ago
|
||
Comment on attachment 593539 [details] [diff] [review] patch Looks good, but I want Sriram to be aware of this too and look for any issues
Attachment #593539 -
Flags: review?(mark.finkle)
Attachment #593539 -
Flags: review+
Attachment #593539 -
Flags: feedback?(sriram)
Comment 4•12 years ago
|
||
Comment on attachment 593539 [details] [diff] [review] patch Review of attachment 593539 [details] [diff] [review]: ----------------------------------------------------------------- The v8 was added thinking that we wouldn't be supporting eclair. I am happy with this change :) I am not sure if we want LDPI version. If I remember correctly we don't support LDPI.
Attachment #593539 -
Flags: feedback?(sriram) → feedback+
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #4) > Comment on attachment 593539 [details] [diff] [review] > patch > > Review of attachment 593539 [details] [diff] [review]: > ----------------------------------------------------------------- > > The v8 was added thinking that we wouldn't be supporting eclair. I am happy > with this change :) > I am not sure if we want LDPI version. If I remember correctly we don't > support LDPI. we don't, but sync has an LDPI resource.
Comment 6•12 years ago
|
||
Probably we need to ask Sync team if they really want those resources (I believe they use eclipse and eclipse created the ldpi folder by default). If they don't want, we can remove it some day. If they want it, we should think of copying low resolution images into drawable-ldpi to make us LDPI devices ready.
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f7a88134a0f7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 593539 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): User impact if declined: crash on startup on eclair Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch:
Attachment #593539 -
Flags: approval-mozilla-beta?
Attachment #593539 -
Flags: approval-mozilla-aurora?
Comment 9•12 years ago
|
||
Verified fixed on: Mozilla/5.0 (Android;Linux armv7l;rv:13.0a1)Gecko/20120203 Firefox/13.0a1 Fennec/13.0a1 Device: Samsung Galaxy S OS: Android 2.1-update1
status-firefox12:
--- → affected
status-firefox13:
--- → fixed
Comment 10•12 years ago
|
||
Aurora nom?
Comment 11•12 years ago
|
||
(In reply to Cristian Nicolae (:xti) from comment #10) > Aurora nom? See the patch above. It's question marked already.
Comment 12•12 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #11) > (In reply to Cristian Nicolae (:xti) from comment #10) > > Aurora nom? > > See the patch above. It's question marked already. Sorry, I just missed it. Thanks
Comment 13•12 years ago
|
||
Comment on attachment 593539 [details] [diff] [review] patch [Triage Comment] Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593539 -
Flags: approval-mozilla-beta?
Attachment #593539 -
Flags: approval-mozilla-beta+
Attachment #593539 -
Flags: approval-mozilla-aurora?
Attachment #593539 -
Flags: approval-mozilla-aurora+
Comment 14•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7c4652b0f3b0
status-firefox11:
--- → affected
Assignee | ||
Comment 15•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/02d946fad4c7
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•