Base64.decode not available on eclair

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

unspecified
Firefox 13
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed, firefox13 verified)

Details

Attachments

(1 attachment)

We use this for tab screenshots and something else I that I can't remember right now.

W/System.err(  445): java.lang.NoClassDefFoundError: android.util.Base64
W/System.err(  445): 	at org.mozilla.gecko.Tabs.handleMessage(Tabs.java:282)
W/System.err(  445): 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:1645)
W/System.err(  445): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
W/System.err(  445): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
Depends on: 662891
Created attachment 593543 [details] [diff] [review]
patch
Assignee: nobody → blassey.bugs
Attachment #593543 - Flags: review?(mark.finkle)
Attachment #593543 - Flags: review?(mark.finkle) → review+
Comment on attachment 593543 [details] [diff] [review]
patch

There's a base64 implementation in mobile/android/base/apache/commons/codec/binary/ - can we not reuse that one?
(In reply to Kartikaya Gupta (:kats) from comment #2)
> Comment on attachment 593543 [details] [diff] [review]
> patch
> 
> There's a base64 implementation in
> mobile/android/base/apache/commons/codec/binary/ - can we not reuse that one?

that is from sync, and will hopefully be going away soon. Fennec code should not depend on it.
https://hg.mozilla.org/mozilla-central/rev/9022268bea45
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593543 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined:
crash on eclair 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #593543 - Flags: approval-mozilla-beta?
Attachment #593543 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Depends on: 723870
Depends on: 723955

Comment 6

6 years ago
Comment on attachment 593543 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593543 - Flags: approval-mozilla-beta?
Attachment #593543 - Flags: approval-mozilla-beta+
Attachment #593543 - Flags: approval-mozilla-aurora?
Attachment #593543 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-beta/rev/09b1dc4ff4a9
status-firefox11: --- → fixed
Verified fixed on:

Firefox 13.0a1 (2012-03-06)
20120306031101
http://hg.mozilla.org/mozilla-central/rev/7d0d1108a14e

--
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
status-firefox13: --- → verified
This bug needs a 2.1 (Eclair) phone to be verified. This is currently broken by other work. To verify you would need to use a build near the checkin date of 2012-02-02.
Status: VERIFIED → RESOLVED
Last Resolved: 6 years ago6 years ago
(In reply to Kevin Brosnan [:kbrosnan] from comment #9)
> This bug needs a 2.1 (Eclair) phone to be verified. This is currently broken
> by other work. To verify you would need to use a build near the checkin date
> of 2012-02-02.

Right, I will check it again on a 2.1 device. My mistake, sorry.
You need to log in before you can comment on or make changes to this bug.