723159 - Base64.decode not available on eclair

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

We use this for tab screenshots and something else I that I can't remember right now.

W/System.err(  445): java.lang.NoClassDefFoundError: android.util.Base64
W/System.err(  445): 	at org.mozilla.gecko.Tabs.handleMessage(Tabs.java:282)
W/System.err(  445): 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:1645)
W/System.err(  445): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
W/System.err(  445): 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 593543 [details] [diff] [review]
patch

There's a base64 implementation in mobile/android/base/apache/commons/codec/binary/ - can we not reuse that one?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Kartikaya Gupta (:kats) from comment #2)
> Comment on attachment 593543 [details] [diff] [review]
> patch
> 
> There's a base64 implementation in
> mobile/android/base/apache/commons/codec/binary/ - can we not reuse that one?

that is from sync, and will hopefully be going away soon. Fennec code should not depend on it.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9022268bea45

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 593543 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined:
crash on eclair 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 593543 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/09b1dc4ff4a9

Comment 8

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-03-06)
20120306031101
http://hg.mozilla.org/mozilla-central/rev/7d0d1108a14e

--
Device: HTC Desire
OS: Android 2.2

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

This bug needs a 2.1 (Eclair) phone to be verified. This is currently broken by other work. To verify you would need to use a build near the checkin date of 2012-02-02.

Comment 10

[Cristian Nicolae (:xti)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #9)
> This bug needs a 2.1 (Eclair) phone to be verified. This is currently broken
> by other work. To verify you would need to use a build near the checkin date
> of 2012-02-02.

Right, I will check it again on a 2.1 device. My mistake, sorry.