Closed Bug 723197 Opened 9 years ago Closed 5 years ago

Possible compiler bug with MSVC 2010 causes miscompilation of CSSParserImpl::ParseProperty

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: khuey, Assigned: m_kato)

References

Details

Attachments

(1 file)

Ftr, a |#pragma optimize( "", off )| was added as a workaround in bug 563318 comment 39:
https://hg.mozilla.org/mozilla-central/rev/a54f31fa1efd
Version: unspecified → Trunk
try again. no PGO error of original.  (although hitting bug1115490 after building successful)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5e91d698177
Comment on attachment 8588523 [details] [diff] [review]
Remove old workaround of VS2010

When using VS2010, it throws ICE (internal compiler error) when building source file.

But using VS2013, no error when building and linking.
Attachment #8588523 - Flags: review?(mshal)
Comment on attachment 8588523 [details] [diff] [review]
Remove old workaround of VS2010

Although the change looks fine to me, I think you'll need someone in this module for review.

Also the "command timed out" error may or may not be related. That just means that something in the build is hanging - it's possible this patch is introducing a new thing that times out, though that is probably unlikely.
Attachment #8588523 - Flags: review?(mshal)
Comment on attachment 8588523 [details] [diff] [review]
Remove old workaround of VS2010

try server is successful during PGO building on VS2013.

When using VS2010, ICE (internal compile error on building) occurred.
Attachment #8588523 - Flags: review?(dbaron)
Attachment #8588523 - Flags: review?(dbaron) → review+
Assignee: nobody → m_kato
https://hg.mozilla.org/mozilla-central/rev/38291788a6f4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Duplicate of this bug: 744354
You need to log in before you can comment on or make changes to this bug.