Closed Bug 723197 Opened 10 years ago Closed 6 years ago
Possible compiler bug with MSVC 2010 causes miscompilation of CSSParser
No description provided.
10 years ago
Ftr, a |#pragma optimize( "", off )| was added as a workaround in bug 563318 comment 39: https://hg.mozilla.org/mozilla-central/rev/a54f31fa1efd
Version: unspecified → Trunk
no PGO error on our VS2013 builder https://treeherder.mozilla.org/#/jobs?repo=try&revision=47b6686624b3
try again. no PGO error of original. (although hitting bug1115490 after building successful) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5e91d698177
Comment on attachment 8588523 [details] [diff] [review] Remove old workaround of VS2010 When using VS2010, it throws ICE (internal compiler error) when building source file. But using VS2013, no error when building and linking.
Comment on attachment 8588523 [details] [diff] [review] Remove old workaround of VS2010 Although the change looks fine to me, I think you'll need someone in this module for review. Also the "command timed out" error may or may not be related. That just means that something in the build is hanging - it's possible this patch is introducing a new thing that times out, though that is probably unlikely.
Comment on attachment 8588523 [details] [diff] [review] Remove old workaround of VS2010 try server is successful during PGO building on VS2013. When using VS2010, ICE (internal compile error on building) occurred.
Attachment #8588523 - Flags: review?(dbaron)
You need to log in before you can comment on or make changes to this bug.