The default bug view has changed. See this FAQ.

SimpleScaleGestureDetector uses getActionIndex(), which is not available in eclair

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

unspecified
Firefox 13
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 fixed)

Details

Attachments

(1 attachment)

Created attachment 593554 [details] [diff] [review]
patch

This is just a convenience function which was introduced in Froyo. It is the equivalent of: 

(event.getAction() & MotionEvent.ACTION_POINTER_ID_MASK) >> MotionEvent.ACTION_POINTER_ID_SHIFT

but, ACTION_POINTER_ID_* was renamed to ACTION_POINTER_INDEX_* in Froyo, so I used those constants in the patch
Attachment #593554 - Flags: review?(wjohnston)
Attachment #593554 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/6befd1389592
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593554 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Crash when touching on eclair
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #593554 - Flags: approval-mozilla-beta?
Attachment #593554 - Flags: approval-mozilla-aurora?

Comment 3

5 years ago
Comment on attachment 593554 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593554 - Flags: approval-mozilla-beta?
Attachment #593554 - Flags: approval-mozilla-beta+
Attachment #593554 - Flags: approval-mozilla-aurora?
Attachment #593554 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/49f5c924b7a5
status-firefox11: --- → affected
status-firefox12: --- → fixed
status-firefox13: --- → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/02d946fad4c7
status-firefox11: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/1e79aa665449
(In reply to Brad Lassey [:blassey] from comment #5)
> https://hg.mozilla.org/releases/mozilla-beta/rev/02d946fad4c7

this is actually bug 723151's patch
You need to log in before you can comment on or make changes to this bug.