723280 - Add an em:updateURL tag for nightly builds only

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

See bug 322522 for the bigger picture.

When everything else is in place, we need to add an em:updateURL pointing to the right location, but only for official nightly builds.

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Aside from using the correct hostname, this should fix the source tree side of things. Now we just need buildbot to pass the variable on comm-aurora and comm-central.

I guess this could either be done by modifying the mozconfigs or by changing the buildstep. Mark, which do you think is better/will actually work?

pro-buildstep: when mozconfigs move to source tree, adding this variable there will likely be wrong

pro-mozconfig: maybe easier to set up, i.e it can be done for nightly configs only.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 603498 [details] [diff] [review]
Fix - v1

r=me for when you get the proper url.

I would do the env var within a buildbot step. It is easy to add env vars there and is generally what we do with this type of thing.

In fact if you wanted, you could probably make the value an env var as well, although maybe that's going overboard.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central changeset 40f36996a1e2

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Backported to releases/comm-aurora changeset ebfaf6f7fe19

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Buildbot Changes - v1

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to buildbot-configs changeset 028d97e4a525

I'm excited, lets see how this goes!

Comment 7

[Stefan Sitter [:ssitter]]

Doesn't seem to work. I don't see any em:updateURL in todays comm-central/comm-aurora linux/linux64 nightly package.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Yep, I forgot to reconfigure the buildbot. Before I do that I'm going to make sure beta 2 is working since right now it is configured for beta 2.

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Changes pulled, buildbot reconfiged. Lets hope it works better this time :-)

Comment 10

[Stefan Sitter [:ssitter]]

From a quick look it seems to work now i.e. em:updateURL is set.

But the URL doesn't work. Seems the update check got redirected to the calendar homepage and instead of the update manifest file the normal homepage content is served.

Error: mismatched tag. Expected: </link>.
Source file: http://www.mozilla.org/projects/calendar/?buildID=20120525092041&appABI=x86-msvc&appOS=WINNT&locale=en-US&appVersion=14.0a2&appID=%7b3550f703-e582-4d05-9a08-453d09bdfdc6%7d
Line: 34, Column: 3
Source code:
</head>

Is this a known problem? Is this the right location to discuss? Or open a new bug?

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Duh, a typo on my side. It should be update.php not upload.php!

Fixed in build/buildbot-configs changeset 29087b92e924

The next nightly builds should work better.

Comment 12

[Stefan Sitter [:ssitter]]

I still get the wrong upload.php link in todays build.