Closed
Bug 723311
Opened 12 years ago
Closed 12 years ago
[shipping] team snippet should have sign-off buttons in action-required order
Categories
(Webtools Graveyard :: Elmo, defect, P2)
Webtools Graveyard
Elmo
Tracking
(Not tracked)
RESOLVED
FIXED
2.1
People
(Reporter: Pike, Assigned: peterbe)
References
Details
Attachments
(1 file)
2.69 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
When looking at the new team page, Milos suggested to order the buttons for sign-offs in the order of action-required, that is, instead of accepted, pending, suggested, rejected order them as rejected, suggested, pending, accepted. Jason, we took much of what we're doing from your input in bug 696446, so CCing you for feedback here, too.
Comment 1•12 years ago
|
||
That totally sounds like a great idea to me!
Reporter | ||
Comment 2•12 years ago
|
||
The button snippets get a good change in bug 713878, so marking a dependency on that. Also, it might be good to re-use the left-most button or so to link to the sign-off view in case there's no pre-existing sign-off nor a suggested one. Just to keep that page accessible.
Depends on: 713878
Priority: -- → P2
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → peterbe
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #599791 -
Flags: review?(l10n)
Reporter | ||
Updated•12 years ago
|
Attachment #599791 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://github.com/mozilla/elmo/commit/decb0678b079aad25312f30c951a42f014063897
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•12 years ago
|
Target Milestone: --- → 2.1
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•