723356 - Make `console` output show up in logcat

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Philipp von Weitershausen [:philikon]]

Need this to debug gaia. Patch incoming.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Pretty ghetto but also pretty handy. This gets us output like:

  E/GeckoConsole( 2628): Content JS LOG at http://localhost:6666/apps/dialer/js/dialer.js:298 in fm_handleEvent: Call changed state: disconnected

when gaia calls console.log(...);

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 593683 [details] [diff] [review]
v1

The |message| here is an instance of

http://mxr.mozilla.org/mozilla-central/source/dom/base/ConsoleAPI.js#198

The arguments of that come from content at some point.  Need to be sure that toString()ing them doesn't result in content code being called unsafely from chrome.

Comment 3

[Philipp von Weitershausen [:philikon]]

(Note that Firefox [1] and Fennec [2,3] do the same in terms of toString()ing.

[1] https://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/HUDService.jsm#5116
[2] https://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/content.js#1243
[3] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3565
)

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

For future reference, the only way we know out of the toString() box is this.caller, and Andreas points at

 /* Censor the caller if it is from another compartment. */
       JSObject &caller = vp->toObject();
       if (caller.compartment() != cx->compartment) {
jsfun.cpp:1141

so this is OK.

Comment 5

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/315820aa1d28