72342 - about:blank loaded twice when opening a blank new nav window!

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[David Hyatt]

All new nav windows start off with about:blank loaded.  In the case where 
you've opened a new blank window, we load about:blank a second time!

Comment 1

[Jesse Ruderman]

Related to bug 66034?

Comment 2

[David Hyatt]

Attachment: Patch this in the docshell, so no matter how crazy the XUL/JS gets, we're ok.

Comment 3

[David Hyatt]

Wow.  There are two other code paths that cause this to happen.  The way box
interacts with iframe on a reflow causes a double-load, and the navigator JS
triggers a reload (which should never do anything for about:blank).

The following patch fixes all cases and ensures that about:blank is exempt from
all this madness.

Comment 4

[David Hyatt]

Attachment: This solves it for good.

Comment 5

[Peter "jag" Annema]

r=jag

Comment 6

[Scott Collins]

sr=scc (based on the notion that |SchemeIs| will be getting better, so playing
to its strengths is wise)

Comment 7

[David Hyatt]

Turns out editor needs the double load... they have to monitor loads of docs,
even about:blank.  So I'm patching navigator only.  The fix is to navigator.js
instead of to docshell.

Comment 8

[David Hyatt]

Attachment: Fix in navigator only.

Comment 9

[David Hyatt]

Need a fresh r and sr.

Comment 10

[Peter "jag" Annema]

The change to navigator.js is also needed for bug 70682. r=jag on this.

What's the patch to BrowserInstance for? Accidentally included?

Comment 11

[Peter "jag" Annema]

Attachment: [patch] better fix. I suck.

Comment 12

[David Hyatt]

sr=hyatt

Comment 13

[Håkan Waara]

r=hwaara

Comment 14

[David Hyatt]

Reassigning to jag.

Comment 15

[Asa Dotzler [:asa]]

a=asa on (behalf of drivers)

Comment 16

[Peter "jag" Annema]

Checked in on both the trunk and the branch. Marking fixed.